fix: remove alarms permission from Chrome extension#906
Merged
Conversation
The alarm was added in #650 to keep the offscreen document alive for the bridge WebSocket. The bridge was removed in v0.27.0 but the alarm remained. The offscreen document's own setInterval (10s health check) prevents Chrome from killing it, making the alarm redundant. Closes #906 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alarmspermission from manifest.json — rejected by Chrome Web Store reviewsetInterval(10s health check in offscreen.ts:128) keeps it alive and handles WebSocket reconnection, making the alarm redundantContext
The alarm was added in #650 for the bridge WebSocket keepalive. The bridge was removed in v0.27.0 but the alarm remained as dead code.
Test plan
pnpm run buildpassespnpm test— all unit tests pass🤖 Generated with Claude Code