Skip to content

Fix workspace history, recovery, and build cancellation - #206

Merged
stevenmunn312-tech merged 1 commit into
Hardwarefrom
codex/bug-hunt-top-five
Oct 29, 2026
Merged

stevenmunn312-tech merged 1 commit into
Hardwarefrom
codex/bug-hunt-top-five

Conversation

@stevenmunn312-tech

@stevenmunn312-tech stevenmunn312-tech commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Fix the five highest-ranked findings from the 2026-10-29 bug hunt. This targets Hardware, where the findings were reproduced.

  • Flush and clear pending history on project loads so undo cannot restore another project and autosave it under the current name.
  • Restore trust safely during undo/redo without remembering unknown code as trusted.
  • Capture and restore complete recovery workspaces, including custom display documents and music metadata, with an explicit undo/redo checkpoint.
  • Flush pending edits before entering a group so root history cannot enter the group's undo stack.
  • Give each build a cancellation token across subprocess phases and streaming worker changes. Capacity checks do not own the upload Cancel button. Cancellation returns a nonzero sentinel even when the compiler exits successfully.

Validation:

  • Full frontend suite: 522 files passed, 7 skipped; 8,643 tests passed, 138 skipped (npm test -- --maxWorkers=3).
  • Full backend suite: 304 tests passed (python -m pytest backend/tests -q).
  • npm run lint and npm run build passed. Vite retains circular-chunk and chunk-size warnings.

Regression tests cover project switching, group navigation, foreign-code trust, recovery undo/redo, overlapping builds, startup races, cancellation between compile and upload, and abandoned-stream cleanup. No hardware flashing was performed.

Co-Authored-By: Codex <noreply@anthropic.com>
@stevenmunn312-tech
stevenmunn312-tech marked this pull request as ready for review October 29, 2026 11:53
@stevenmunn312-tech
stevenmunn312-tech merged commit 6273426 into Hardware Oct 29, 2026
2 checks passed
@stevenmunn312-tech
stevenmunn312-tech deleted the codex/bug-hunt-top-five branch October 29, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant