fix(deps): bump brace-expansion override floors to patched versions - #249
Open
stevenfackley wants to merge 2 commits into
Open
fix(deps): bump brace-expansion override floors to patched versions#249stevenfackley wants to merge 2 commits into
stevenfackley wants to merge 2 commits into
Conversation
npm audit gate was failing on GHSA-mh99-v99m-4gvg: the existing brace-expansion@1 override floor (^1.1.16) sat below the patched 1.1.17, so every resolution chain through eslint/minimatch stayed vulnerable. Bump @1 to ^1.1.17 and @2 to ^2.1.3; audit now reports 0 vulnerabilities.
brace-expansion 1.1.17 shipped upstream, so the entry's premise (no fixed 1.x release) no longer holds and the gate rightly demands its removal now that the floor bump resolves the advisory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontend
npm audit --audit-level=moderategate fails on every PR (including all three open Dependabot PRs) because thebrace-expansion@1override floor^1.1.16is below the patched1.1.17for GHSA-mh99-v99m-4gvg.brace-expansion@1override to^1.1.17,@2to^2.1.3npm auditnow reports 0 vulnerabilitiesUnblocks Dependabot #245, #244, #240 (rebase after merge).