Skip to content

fix(progress): record a subagent's progress from its own checkout and let a ticket start in a stage; bump to 1.14.7 - #137

Merged
stevecastaneda merged 1 commit into
mainfrom
fix-progress-skill-field-guessing
Nov 13, 2026
Merged

stevecastaneda merged 1 commit into
mainfrom
fix-progress-skill-field-guessing

Conversation

@steve-dev-bot

@steve-dev-bot steve-dev-bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Agents should record progress on the first try. In six sessions on 2026-11-12, their Progress calls failed in three ways, and each failure started in the plugin, not in the agent.

  • The skill told a subagent to cd to its agent's worktree before paseo-progress. Claude Code refuses that command for an isolated subagent when the command also runs git. In one session Claude Code refused 9 such commands.
  • ticket add refused --stage. Agents add a step that is already under way with its stage. The step was never added, and each later step that waited for it failed too. Four sessions hit this.
  • paseo-progress ticker set "" asked for text, though the progress_ticker tool hides the line for "".

What changed

  • From a .claude/worktrees/<name> checkout, paseo-progress records on the dashboard of the workspace that Paseo names in PASEO_AGENT_CWD. The skill's subagent prompt drops the cd.
  • ticket add and progress_ticket_add take a stage.
  • ticker set "" hides the ticker. The tool now passes "" to the command.

Scope

  • Claude Code subagent checkouts. Other checkouts and commands run outside Paseo keep the dashboard of the folder they run in.
  • One agent passed --title and --target to deliverable add. The usage line corrected it on the next call, so the command still takes them as plain arguments.

Blast Radius

Every agent that records progress gets the new command and skill. Old progress files read as before, because the new stage on a ticket.add event is optional. A subagent's updates now land on its agent's dashboard, where the agent tools already put them.

Verification

  • A real subagent with isolation: "worktree" ran paseo-progress ticket update T03 --stage Verify; paseo-progress ticker set "…"; git status --short from its own checkout. Claude Code ran it, and paseo-progress show listed the agent's worktree with both updates. Before the fix, the same probe recorded on a dashboard nobody watches.
  • npm test in progress: 237 pass. npm run typecheck, oxlint and oxfmt --check are clean.
  • npm run check:install installs with npm 10.9.9 and npm 12.2.2.

Security review

No release blockers found.

Full report

Security review: @stevecastaneda/paseo-progress@1.14.7

  • Reviewer: claude --model opus
  • Commit: 2091d77
  • Tree: fe9569e18b3f47bd0532f515c63617dbac9674be
  • Diff: 7f08467..2091d77 -- progress/
  • Date: 2026-11-13T13:37:51.854Z
  • Minutes: 1.2
  • Key: ecdbab7fb69d32c85d1cd3cb7d0f10864b86c6e51a1463672defcb7a848a85e5

I found no release blockers in @stevecastaneda/paseo-progress 1.14.7 against items 1 to 4. I didn't run anything (I only had read and search tools); everything below comes from reading the source.

What changed

Subagent routing (server/paths.ts:41-46, server/cli.ts:578,607,644-649). If the folder the command runs from sits under .claude/worktrees/<name> and PASEO_AGENT_CWD is set, the command now records on the dashboard of findRoot(PASEO_AGENT_CWD) instead.

  • Repo content can't exploit it. A committed repo could create that folder layout, for example with a submodule at .claude/worktrees/x. But the most it does is pick which worktree's dashboard gets the event. That target comes from Paseo's environment variable, which the repo doesn't control.
  • An agent gains nothing new. It could set PASEO_AGENT_CWD itself, but it can already cd to any folder and run paseo-progress. The agent tools ignore this path entirely: they pass agent.cwd and no agentCwd (server/tool.ts:28).
  • Where the writes land. The event still goes to ~/.local/state/paseo-progress/<name>-<hash>/ through appendFileIn. The saved-history copy (saveRunCopy) still goes to the folder the user chose in that worktree's local git config, written through makeFoldersIn/writeFileIn on the real path, which refuse links and ...
  • Recorded paths. Paths are now stored relative to the agent's worktree. A path from a checkout outside that worktree is stored as an absolute path, and the panel refuses to open or preview those (server/open.ts:74-79).

stage on ticket add (cli.ts:238-242, tool.ts:98-103, shared/events.ts:55, shared/dashboard.ts:268-270). It's a plain text field, checked by the event schema and shown as text. Like every other agent-written field, it only appears on the dashboard, which is clearly agent output.

Empty ticker (cli.ts:483, tool.ts:187). Passing "" now writes a ticker.clear event. No files, programs or HTML are involved.

SKILL.md and README. These are text changes only. The subagent prompt no longer tells agents to cd, so it runs fewer commands than before.

Places that touch files, programs, HTML or the network

  • server/progress-file.ts:67,80,87: makes, appends to and writes files only in the plugin's own state folder, named by a hash of the worktree path; placeIn refuses .. and links. Safe.
  • server/store.ts:134-151 (saveRunCopy): writes inside the real worktree, in a folder that has to pass checkFolder (inside the repo, not .git). It builds that folder step by step, gives up at any link or file, and renames into place atomically. The folder comes from the user's local git config, which the repo can't set. Safe.
  • server/store.ts:20-28 (git): runs git -C <root> from Node's own folder (LAUNCH_FOLDER), never the worktree's, so a git.exe committed to the repo isn't picked up. Safe.
  • server/system.ts: the only module that starts programs or changes files. Programs start in LAUNCH_FOLDER; writes check for links and ... Safe.
  • server/open.ts:67-91 (resolveAttachment, openDeliverable): looks a deliverable up by reference from the progress file, resolves the real path and refuses anything outside the worktree. It opens only real files of image, video, audio, PDF or text types, with explorer, xdg-open or open given a list of arguments, not a shell. Safe.
  • server/open.ts:117-178 (previews): same checks, with size limits. HTML isn't previewed on the server. Text is read only up to 256 KB. Safe.
  • server/open.ts:38-47: runs plutil on the user's own Launch Services settings file. No input from the repo or agent. Safe.
  • server/launcher.ts:128-173: writes only to ~/.local/bin/paseo-progress when the user presses Install, never replaces a file it didn't write, and the paseo_progress tool refuses install-launcher (tool.ts:203). The launcher runs paseo from Node's folder. Safe.
  • server/skill.ts: links the skill folder in ~/.agents, ~/.claude and ~/.codex, only on Install or to repoint links it made itself. On Windows, cmd.exe starts with LAUNCH_FOLDER as its working folder. Safe.
  • server/question-mode.ts:33,64 and server/whats-new.ts:109: write only in the plugin's state folder. Safe.
  • server/lock.ts: makes and removes a lock folder inside the state folder. Safe.
  • client/attachments.tsx:66-84: web links open in Paseo's browser or through openExternalUrl, and only http(s) links can be recorded (cli.ts:107,423). HTML pages open in Paseo's own preview, which loads nothing from the web. Any other file opens through the server's checks above, or its path is copied. Safe.
  • client/pdf.tsx and client/video.tsx: show bytes the checked server sent, through blob URLs. Safe.
  • shared/markdown.ts: links and images in a Markdown preview resolve relative to the file's own folder inside the worktree, and the files they point to go through the same server checks. Safe.

No release blockers found.

… let a ticket start in a stage; bump to 1.14.7

In six sessions on 2026-11-12, agents' Progress calls failed in three ways.

A Claude Code subagent that works in its own checkout had to change to
its agent's worktree to record progress, because the skill told it to.
Claude Code refuses that command when it also runs git. The command now
sends progress from a .claude/worktrees checkout to the workspace that
Paseo names in PASEO_AGENT_CWD, and the skill drops the cd.

`ticket add` refused --stage. Agents add a step that is already under
way with its stage, so the step was never added and each later step
that waited for it failed too. `ticket add` and progress_ticket_add now
take a stage.

`ticker set ""` asked for text, though progress_ticker hides the line
for "". The command now hides it too, and the tool passes "" through.
@stevecastaneda
stevecastaneda merged commit 5929e52 into main Nov 13, 2026
1 check passed
@stevecastaneda
stevecastaneda deleted the fix-progress-skill-field-guessing branch November 13, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants