Repository navigation
fix(progress): record a subagent's progress from its own checkout and let a ticket start in a stage; bump to 1.14.7 - #137
Merged
Conversation
… let a ticket start in a stage; bump to 1.14.7 In six sessions on 2026-11-12, agents' Progress calls failed in three ways. A Claude Code subagent that works in its own checkout had to change to its agent's worktree to record progress, because the skill told it to. Claude Code refuses that command when it also runs git. The command now sends progress from a .claude/worktrees checkout to the workspace that Paseo names in PASEO_AGENT_CWD, and the skill drops the cd. `ticket add` refused --stage. Agents add a step that is already under way with its stage, so the step was never added and each later step that waited for it failed too. `ticket add` and progress_ticket_add now take a stage. `ticker set ""` asked for text, though progress_ticker hides the line for "". The command now hides it too, and the tool passes "" through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agents should record progress on the first try. In six sessions on 2026-11-12, their Progress calls failed in three ways, and each failure started in the plugin, not in the agent.
cdto its agent's worktree beforepaseo-progress. Claude Code refuses that command for an isolated subagent when the command also runs git. In one session Claude Code refused 9 such commands.ticket addrefused--stage. Agents add a step that is already under way with its stage. The step was never added, and each later step that waited for it failed too. Four sessions hit this.paseo-progress ticker set ""asked for text, though theprogress_tickertool hides the line for"".What changed
.claude/worktrees/<name>checkout,paseo-progressrecords on the dashboard of the workspace that Paseo names inPASEO_AGENT_CWD. The skill's subagent prompt drops thecd.ticket addandprogress_ticket_addtake a stage.ticker set ""hides the ticker. The tool now passes""to the command.Scope
--titleand--targettodeliverable add. The usage line corrected it on the next call, so the command still takes them as plain arguments.Blast Radius
Every agent that records progress gets the new command and skill. Old progress files read as before, because the new
stageon aticket.addevent is optional. A subagent's updates now land on its agent's dashboard, where the agent tools already put them.Verification
isolation: "worktree"ranpaseo-progress ticket update T03 --stage Verify; paseo-progress ticker set "…"; git status --shortfrom its own checkout. Claude Code ran it, andpaseo-progress showlisted the agent's worktree with both updates. Before the fix, the same probe recorded on a dashboard nobody watches.npm testinprogress: 237 pass.npm run typecheck,oxlintandoxfmt --checkare clean.npm run check:installinstalls with npm 10.9.9 and npm 12.2.2.Security review
No release blockers found.
Full report
Security review: @stevecastaneda/paseo-progress@1.14.7
I found no release blockers in
@stevecastaneda/paseo-progress1.14.7 against items 1 to 4. I didn't run anything (I only had read and search tools); everything below comes from reading the source.What changed
Subagent routing (
server/paths.ts:41-46,server/cli.ts:578,607,644-649). If the folder the command runs from sits under.claude/worktrees/<name>andPASEO_AGENT_CWDis set, the command now records on the dashboard offindRoot(PASEO_AGENT_CWD)instead..claude/worktrees/x. But the most it does is pick which worktree's dashboard gets the event. That target comes from Paseo's environment variable, which the repo doesn't control.PASEO_AGENT_CWDitself, but it can alreadycdto any folder and runpaseo-progress. The agent tools ignore this path entirely: they passagent.cwdand noagentCwd(server/tool.ts:28).~/.local/state/paseo-progress/<name>-<hash>/throughappendFileIn. The saved-history copy (saveRunCopy) still goes to the folder the user chose in that worktree's local git config, written throughmakeFoldersIn/writeFileInon the real path, which refuse links and...server/open.ts:74-79).stageonticket add(cli.ts:238-242,tool.ts:98-103,shared/events.ts:55,shared/dashboard.ts:268-270). It's a plain text field, checked by the event schema and shown as text. Like every other agent-written field, it only appears on the dashboard, which is clearly agent output.Empty ticker (
cli.ts:483,tool.ts:187). Passing""now writes aticker.clearevent. No files, programs or HTML are involved.SKILL.md and README. These are text changes only. The subagent prompt no longer tells agents to
cd, so it runs fewer commands than before.Places that touch files, programs, HTML or the network
server/progress-file.ts:67,80,87: makes, appends to and writes files only in the plugin's own state folder, named by a hash of the worktree path;placeInrefuses..and links. Safe.server/store.ts:134-151(saveRunCopy): writes inside the real worktree, in a folder that has to passcheckFolder(inside the repo, not.git). It builds that folder step by step, gives up at any link or file, and renames into place atomically. The folder comes from the user's local git config, which the repo can't set. Safe.server/store.ts:20-28(git): runsgit -C <root>from Node's own folder (LAUNCH_FOLDER), never the worktree's, so agit.execommitted to the repo isn't picked up. Safe.server/system.ts: the only module that starts programs or changes files. Programs start inLAUNCH_FOLDER; writes check for links and... Safe.server/open.ts:67-91(resolveAttachment,openDeliverable): looks a deliverable up by reference from the progress file, resolves the real path and refuses anything outside the worktree. It opens only real files of image, video, audio, PDF or text types, withexplorer,xdg-openoropengiven a list of arguments, not a shell. Safe.server/open.ts:117-178(previews): same checks, with size limits. HTML isn't previewed on the server. Text is read only up to 256 KB. Safe.server/open.ts:38-47: runsplutilon the user's own Launch Services settings file. No input from the repo or agent. Safe.server/launcher.ts:128-173: writes only to~/.local/bin/paseo-progresswhen the user presses Install, never replaces a file it didn't write, and thepaseo_progresstool refusesinstall-launcher(tool.ts:203). The launcher runspaseofrom Node's folder. Safe.server/skill.ts: links the skill folder in~/.agents,~/.claudeand~/.codex, only on Install or to repoint links it made itself. On Windows,cmd.exestarts withLAUNCH_FOLDERas its working folder. Safe.server/question-mode.ts:33,64andserver/whats-new.ts:109: write only in the plugin's state folder. Safe.server/lock.ts: makes and removes a lock folder inside the state folder. Safe.client/attachments.tsx:66-84: web links open in Paseo's browser or throughopenExternalUrl, and onlyhttp(s)links can be recorded (cli.ts:107,423). HTML pages open in Paseo's own preview, which loads nothing from the web. Any other file opens through the server's checks above, or its path is copied. Safe.client/pdf.tsxandclient/video.tsx: show bytes the checked server sent, through blob URLs. Safe.shared/markdown.ts: links and images in a Markdown preview resolve relative to the file's own folder inside the worktree, and the files they point to go through the same server checks. Safe.No release blockers found.