Skip to content

fix(progress): spin only while an agent is running; bump to 1.14.6 - #136

Merged
stevecastaneda merged 8 commits into
mainfrom
progress-pill-static-icon
Nov 8, 2026
Merged

stevecastaneda merged 8 commits into
mainfrom
progress-pill-static-icon

Conversation

@stevecastaneda

Copy link
Copy Markdown
Owner

Why

The Progress pill and panel showed a spinner when nothing was happening. The pill spun until you first opened the panel, even after every ticket was done or the agent had stopped. The panel kept spinning for up to 15 minutes after the agent stopped. If the agent never closed the run, the line under the title spun for good. Now a spinner means that an agent in the worktree is running.

What changed

  • AttentionResult reports the run as closed, ticketsLeft, or ticketsSettled in place of runOpen. The pill spins only when tickets are left and the workspace status is running. Otherwise it shows the checklist icon.
  • The panel computes one Liveness value (running, paused, or stalled) and passes it where the live flag went. A paused item shows a still dot. After 15 minutes with no update, the amber warning appears as before.
  • Once every ticket is done or skipped, the line under the title shows the green check, even before the agent calls finish.

Scope

  • Covers the pill on desktop and phones, and the panel's status line, ticket rows, progress bar, and ticket timeline.
  • The rules for when the pill appears or goes away stay the same.
  • The store screenshots stay. They show an agent at work, and that state looks the same as before.

Blast radius

AttentionResult changes shape, and the client and the server ship together. A Paseo window that still runs the old client against the new server shows no pill until it reloads.

Verification

  • A private Paseo 0.14 with an idle agent. Before the change, the pill and the panel's status line spun with 2 of 2 tickets done. After it, the pill shows the checklist, the status line shows the check, and a ticket in progress shows a still dot. The private copy can't run an agent, so unit tests cover the spinner while an agent runs.
  • npm test passes 234 of 234. Typecheck, lint, and format pass. npm run check:install prints ok on npm 10.9.9 and 12.2.2.

Security review

No release blockers found.

Full report

Security review: @stevecastaneda/paseo-progress@1.14.6

  • Reviewer: claude --model opus
  • Commit: f1df1d5
  • Tree: 42a0d460ebb2260f67148ce16b1cfcbd7b66406e
  • Diff: fe1ffac..f1df1d5 -- progress/
  • Date: 2026-11-08T16:40:40.736Z
  • Minutes: 1.3
  • Key: 1ed975776ea648bdaf4ab9b3833759151d4f494e568a7999f68bac2c54f6cc4e

I reviewed version 1.14.6 by reading the source only. I had no shell, so I ran nothing, not even the tests. I changed no files.

What changed, and whether it matters for security

  • shared/dashboard.ts: adds three small functions that compute state from the dashboard: hasTicketsAndAllSettled, livenessOf and statusLineState. None of them touch files, programs, HTML or the network. reduceProgress uses hasTicketsAndAllSettled (shared/dashboard.ts:393), which behaves exactly like the old inline check.
  • server/dashboard.ts:46-60: handleGetAttention used to return runOpen: boolean and now returns run: "closed" | "ticketsLeft" | "ticketsSettled". That value comes from the parsed dashboard, which is read from the per-worktree store outside the repo (findStore). It is a fixed set of values, so no attacker text gets through. It reads no new files and adds no new inputs.
  • client/pills.tsx: tracks whether each workspace is running from Paseo's own workspace.status === "running" (pills.tsx:160-166). The host sets that value; an agent can only change it by actually running. It only picks the icon (spinner or checklist) and is never shown as text. The workspace is also removed from the set when it's forgotten (pills.tsx:210).
  • client/pill-state.ts: the pill's icon is now "working" or "checklist". Labels are still fixed text or counts. A closed run now returns no pill.
  • client/panel.tsx, ticket-dialog.tsx, dialog-stack.tsx, spinner.tsx: the live boolean becomes the liveness value. This only changes animations, icons and fixed screen-reader labels (m.waiting, the new m.paused). No attacker text reaches a new place, and nothing new opens files or links.
  • Locales, README, package.json and the lock file: text and version bump only. No new dependencies.

Nothing in the change reaches files, programs, HTML or the network.

Every place in the shipped plugin that touches files, programs, HTML or the network

  • server/system.ts:24 runProgram: uses execFile with no shell and starts in Node's folder (LAUNCH_FOLDER), never the worktree. A program planted in the repo can't be picked up. Safe.
  • server/system.ts:29 runCommandLine: the only caller is skill.ts:99, which runs on Windows with a command path from the user's env, the default PATH or a fixed install path, plus fixed arguments. It starts in Node's folder, and nothing in it comes from the attacker. Safe.
  • server/system.ts:42-113, the write helpers: refuse absolute names and .., and refuse to write through a link in any folder along the way. Callers only pass folders the plugin trusts. Safe.
  • server/store.ts:20 git: runs git -C <root> through runProgram, so a committed git.exe is never picked up. Safe.
  • server/store.ts:48 findStore: working files live in ~/.local/state/paseo-progress/<name>-<hash>, outside the repo, so the repo can't plant or redirect them. Safe.
  • server/store.ts:77-113, the history folder setting: kept in the repo's local git config, which the attacker doesn't control. It's checked against .., absolute paths and .git in any case. Only the user's own click changes it. Safe.
  • server/store.ts:134 saveRunCopy: creates the folders one step at a time under the worktree's real path and stops at any link or file. The file name is a cleaned slug, written atomically with a rename, so a link at the file gets replaced rather than written through. Safe.
  • server/store.ts:155 listFolders: read-only directory listing inside the worktree, without .git or links. Safe.
  • server/progress-file.ts:37-88: reads and appends progress.jsonl and writes the progress-panel-opened marker, all in the store outside the repo. Every event is checked against the schema before it's written. Safe.
  • server/lock.ts: creates and removes a lock folder in the store using the safe helpers. Safe.
  • server/open.ts:67 resolveAttachment: only follows paths the agent recorded. It checks the real path stays inside the worktree, after links are resolved. Safe.
  • server/open.ts:85 openDeliverable: hands a file to the default app only after the user clicks, and only for kinds that are viewed, never run (opensOnHost, checked on the real file; SVG and HTML are excluded). It uses execFile from Node's folder. Safe.
  • server/open.ts:38 defaultBrowser: runs plutil on a fixed plist in the user's home. Safe.
  • server/open.ts:117-178, preview and piece reads: read-only, inside the worktree, shown only in the user's own panel and sent nowhere else. HTML is refused here; SVG renders as an image. Safe.
  • shared/markdown.ts:326 localTarget: only rewrites relative targets that stay inside the worktree. Anything with a scheme or that starts with /, \, # or ~ is left as it is, and Paseo's own Markdown handles it. Safe.
  • client/attachments.tsx:66-84: a URL attachment opens only when the user clicks it, in Paseo's browser or the system browser; that is the user choosing a link. An HTML page opens in Paseo's own preview, which blocks web requests (shared/attachments.ts:205-209). Safe.
  • client/video.tsx and client/pieces.ts, createObjectURL: build blobs from the already-checked bytes the server sent, inside the client. Safe.
  • server/launcher.ts:128: writes ~/.local/bin/paseo-progress only when the user presses Install, and never overwrites a file the plugin didn't write. The script has no attacker input, and its Windows spawn runs from Node's folder. Safe.
  • server/skill.ts:36-62: links or relinks skill folders in the user's home to the plugin's own copy, and only changes links the plugin made itself. Safe.
  • server/question-mode.ts and server/whats-new.ts: write small JSON files in the plugin's state folder through atomic writes. They read the plugin's own README and package.json from the folder Paseo reports. Safe.
  • server/cli.ts:599-611: agent commands append through appendProgress and save the history copy through saveRunCopy. Both are covered above. Safe.
  • server/dashboard.ts:46 handleGetAttention (changed in this release): read-only and returns only counts and fixed values. Safe.
  • client/pills.tsx workspace status (new in this release): a value Paseo sets, used only to pick an icon. Safe.

No release blockers found.

@stevecastaneda
stevecastaneda merged commit 7f08467 into main Nov 8, 2026
1 check passed
@stevecastaneda
stevecastaneda deleted the progress-pill-static-icon branch November 8, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant