Repository navigation
fix(progress): spin only while an agent is running; bump to 1.14.6 - #136
Merged
Merged
Conversation
…op comments that restated code
… is done (failing)
…keeps the plain name
…restated the code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Progress pill and panel showed a spinner when nothing was happening. The pill spun until you first opened the panel, even after every ticket was done or the agent had stopped. The panel kept spinning for up to 15 minutes after the agent stopped. If the agent never closed the run, the line under the title spun for good. Now a spinner means that an agent in the worktree is running.
What changed
AttentionResultreports the run asclosed,ticketsLeft, orticketsSettledin place ofrunOpen. The pill spins only when tickets are left and the workspace status isrunning. Otherwise it shows the checklist icon.Livenessvalue (running,paused, orstalled) and passes it where theliveflag went. A paused item shows a still dot. After 15 minutes with no update, the amber warning appears as before.finish.Scope
Blast radius
AttentionResultchanges shape, and the client and the server ship together. A Paseo window that still runs the old client against the new server shows no pill until it reloads.Verification
npm testpasses 234 of 234. Typecheck, lint, and format pass.npm run check:installprintsokon npm 10.9.9 and 12.2.2.Security review
No release blockers found.
Full report
Security review: @stevecastaneda/paseo-progress@1.14.6
I reviewed version 1.14.6 by reading the source only. I had no shell, so I ran nothing, not even the tests. I changed no files.
What changed, and whether it matters for security
shared/dashboard.ts: adds three small functions that compute state from the dashboard:hasTicketsAndAllSettled,livenessOfandstatusLineState. None of them touch files, programs, HTML or the network.reduceProgressuseshasTicketsAndAllSettled(shared/dashboard.ts:393), which behaves exactly like the old inline check.server/dashboard.ts:46-60:handleGetAttentionused to returnrunOpen: booleanand now returnsrun: "closed" | "ticketsLeft" | "ticketsSettled". That value comes from the parsed dashboard, which is read from the per-worktree store outside the repo (findStore). It is a fixed set of values, so no attacker text gets through. It reads no new files and adds no new inputs.client/pills.tsx: tracks whether each workspace is running from Paseo's ownworkspace.status === "running"(pills.tsx:160-166). The host sets that value; an agent can only change it by actually running. It only picks the icon (spinner or checklist) and is never shown as text. The workspace is also removed from the set when it's forgotten (pills.tsx:210).client/pill-state.ts: the pill's icon is now"working"or"checklist". Labels are still fixed text or counts. A closed run now returns no pill.client/panel.tsx,ticket-dialog.tsx,dialog-stack.tsx,spinner.tsx: theliveboolean becomes thelivenessvalue. This only changes animations, icons and fixed screen-reader labels (m.waiting, the newm.paused). No attacker text reaches a new place, and nothing new opens files or links.package.jsonand the lock file: text and version bump only. No new dependencies.Nothing in the change reaches files, programs, HTML or the network.
Every place in the shipped plugin that touches files, programs, HTML or the network
server/system.ts:24runProgram: usesexecFilewith no shell and starts in Node's folder (LAUNCH_FOLDER), never the worktree. A program planted in the repo can't be picked up. Safe.server/system.ts:29runCommandLine: the only caller isskill.ts:99, which runs on Windows with a command path from the user's env, the default PATH or a fixed install path, plus fixed arguments. It starts in Node's folder, and nothing in it comes from the attacker. Safe.server/system.ts:42-113, the write helpers: refuse absolute names and.., and refuse to write through a link in any folder along the way. Callers only pass folders the plugin trusts. Safe.server/store.ts:20git: runsgit -C <root>throughrunProgram, so a committedgit.exeis never picked up. Safe.server/store.ts:48findStore: working files live in~/.local/state/paseo-progress/<name>-<hash>, outside the repo, so the repo can't plant or redirect them. Safe.server/store.ts:77-113, the history folder setting: kept in the repo's local git config, which the attacker doesn't control. It's checked against.., absolute paths and.gitin any case. Only the user's own click changes it. Safe.server/store.ts:134saveRunCopy: creates the folders one step at a time under the worktree's real path and stops at any link or file. The file name is a cleaned slug, written atomically with a rename, so a link at the file gets replaced rather than written through. Safe.server/store.ts:155listFolders: read-only directory listing inside the worktree, without.gitor links. Safe.server/progress-file.ts:37-88: reads and appendsprogress.jsonland writes theprogress-panel-openedmarker, all in the store outside the repo. Every event is checked against the schema before it's written. Safe.server/lock.ts: creates and removes a lock folder in the store using the safe helpers. Safe.server/open.ts:67resolveAttachment: only follows paths the agent recorded. It checks the real path stays inside the worktree, after links are resolved. Safe.server/open.ts:85openDeliverable: hands a file to the default app only after the user clicks, and only for kinds that are viewed, never run (opensOnHost, checked on the real file; SVG and HTML are excluded). It usesexecFilefrom Node's folder. Safe.server/open.ts:38defaultBrowser: runsplutilon a fixed plist in the user's home. Safe.server/open.ts:117-178, preview and piece reads: read-only, inside the worktree, shown only in the user's own panel and sent nowhere else. HTML is refused here; SVG renders as an image. Safe.shared/markdown.ts:326localTarget: only rewrites relative targets that stay inside the worktree. Anything with a scheme or that starts with/,\,#or~is left as it is, and Paseo's own Markdown handles it. Safe.client/attachments.tsx:66-84: a URL attachment opens only when the user clicks it, in Paseo's browser or the system browser; that is the user choosing a link. An HTML page opens in Paseo's own preview, which blocks web requests (shared/attachments.ts:205-209). Safe.client/video.tsxandclient/pieces.ts,createObjectURL: build blobs from the already-checked bytes the server sent, inside the client. Safe.server/launcher.ts:128: writes~/.local/bin/paseo-progressonly when the user presses Install, and never overwrites a file the plugin didn't write. The script has no attacker input, and its Windows spawn runs from Node's folder. Safe.server/skill.ts:36-62: links or relinks skill folders in the user's home to the plugin's own copy, and only changes links the plugin made itself. Safe.server/question-mode.tsandserver/whats-new.ts: write small JSON files in the plugin's state folder through atomic writes. They read the plugin's own README andpackage.jsonfrom the folder Paseo reports. Safe.server/cli.ts:599-611: agent commands append throughappendProgressand save the history copy throughsaveRunCopy. Both are covered above. Safe.server/dashboard.ts:46handleGetAttention(changed in this release): read-only and returns only counts and fixed values. Safe.client/pills.tsxworkspace status (new in this release): a value Paseo sets, used only to pick an icon. Safe.No release blockers found.