Repository navigation
fix(progress): close four release blockers from the 1.14.2 security review; bump to 1.14.3 - #131
Merged
Merged
Conversation
…eview; bump to 1.14.3 - Open hands a file to the host's default app only when it is an image, video, audio, PDF or text file, checked on the real file. Scripts, apps, SVG, HTML and folders copy their path; HTML always opens in Paseo. - The paseo_progress agent tool refuses install-launcher. It is the only command that writes outside Progress's state folder and the chosen run-history folder. - A page given any file git ignores gets a Content-Security-Policy that blocks every load and every script except Progress's Escape handler. Measured in Chromium 156: with scripts allowed, a page can still send data by navigating its frame or over WebRTC, so its scripts stay off. - paseo-progress.cmd runs the Node that installed it by full path, and the launcher asks Paseo from Node's folder instead of the agent's.
…ress's page screen Progress showed an HTML deliverable on a screen of its own and copied the files the page loaded into it, which could hand a page a file git ignores. That screen, the file copying and the server's HTML preview are gone. Pressing an HTML deliverable, an HTML file in a folder deliverable, a question attachment or a ticket's write-up now opens it in a Paseo tab, in Paseo's built-in HTML preview. That preview runs the page's own scripts in a sandboxed frame and blocks every load from the web. Plugins can only open a tab through a Markdown link to a local file, so each page row holds one. In a browser the link stays hidden and the row clicks it. On a phone it covers the row, almost clear. The deliverable add help, the agent tool and the skill now tell agents to write self-contained HTML: CSS in the page, images as data URIs, nothing from the web.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every plugin change gets a security review against
THREAT-MODEL.mdbefore its PR. The review for #129 found four release blockers already in published Progress 1.14.2. Each was confirmed in the source. This replaces #130. #129's squash merge left #130's branch with old commits, and this branch is rebuilt on main.What changes
open,xdg-openorexplorer, so a.command,.bator.appcould run. The server checks the real file after links resolve, and the client offers Open only for the same files. Other files copy their path.paseo_progressagent tool passedinstall-launcher <path>through, and that writes an executable file anywhere, such as.git/hooks/pre-commit. The tool now refuses it. The user installs from the panel..env. That screen and all its file copying are gone (page-screen.tsx,inlineLocalFiles, the HTML preview RPC). Pressing an HTML deliverable, folder file, question attachment or write-up now opens it in a Paseo tab. Paseo's preview (builtin:html, also in 0.13) runs the page's own scripts and blocks the network. Progress's agent text, thedeliverable addhelp and the bundled skill now say an HTML deliverable must be self-contained: CSS in the page, images as data URIs, nothing from the web.paseo-progress.cmdran a barenode, which cmd.exe looks for in the agent's folder first. It now runs the absolute Node path, withELECTRON_RUN_AS_NODE=1when Paseo Desktop installed it. Its lookup ofpaseostarts in Node's folder. Existing installs read as outdated once.[Fixed]changelog entries. The minimum stays Paseo 0.13.Checks
format:checkandlintpass. Inprogress/,typecheck,npm test(230 pass),check:installand the Linux run ofcheck:windowspass. The new tests failed before the fix.npm run security-review:No release blockers found.Report at~/.local/state/paseo-plugins/security-review/progress-1.14.3.mdon steve-dev.Not verified
progress-windows.ymlruns the launcher checks on this PR.