Skip to content

fix(progress): close four release blockers from the 1.14.2 security review; bump to 1.14.3 - #131

Merged
stevecastaneda merged 3 commits into
mainfrom
progress-1.14.3-blockers
Nov 7, 2026
Merged

stevecastaneda merged 3 commits into
mainfrom
progress-1.14.3-blockers

Conversation

@stevecastaneda

Copy link
Copy Markdown
Owner

Why

Every plugin change gets a security review against THREAT-MODEL.md before its PR. The review for #129 found four release blockers already in published Progress 1.14.2. Each was confirmed in the source. This replaces #130. #129's squash merge left #130's branch with old commits, and this branch is rebuilt on main.

What changes

  1. Open on host opens only files whose default app shows them: images (not SVG), video, audio, PDF and plain text. It used to pass any file an agent recorded to open, xdg-open or explorer, so a .command, .bat or .app could run. The server checks the real file after links resolve, and the client offers Open only for the same files. Other files copy their path.
  2. Agents can't install the launcher. The paseo_progress agent tool passed install-launcher <path> through, and that writes an executable file anywhere, such as .git/hooks/pre-commit. The tool now refuses it. The user installs from the panel.
  3. HTML reports open in Paseo's own preview. Progress's own page screen copied local files into a report and ran its scripts, and an ignored page could be handed .env. That screen and all its file copying are gone (page-screen.tsx, inlineLocalFiles, the HTML preview RPC). Pressing an HTML deliverable, folder file, question attachment or write-up now opens it in a Paseo tab. Paseo's preview (builtin:html, also in 0.13) runs the page's own scripts and blocks the network. Progress's agent text, the deliverable add help and the bundled skill now say an HTML deliverable must be self-contained: CSS in the page, images as data URIs, nothing from the web.
  4. The Windows launcher names its Node. paseo-progress.cmd ran a bare node, which cmd.exe looks for in the agent's folder first. It now runs the absolute Node path, with ELECTRON_RUN_AS_NODE=1 when Paseo Desktop installed it. Its lookup of paseo starts in Node's folder. Existing installs read as outdated once.
  • Version 1.14.3, with four [Fixed] changelog entries. The minimum stays Paseo 0.13.

Checks

  • Root format:check and lint pass. In progress/, typecheck, npm test (230 pass), check:install and the Linux run of check:windows pass. The new tests failed before the fix.
  • Checked in a private Paseo 0.14.0 web sandbox: a row click, Enter on a focused row, a folder entry, and a question attachment in the pill popover. Each opened one tab with the report, and the page's script ran.
  • npm run security-review: No release blockers found. Report at ~/.local/state/paseo-plugins/security-review/progress-1.14.3.md on steve-dev.

Not verified

  • Phones. The row's link sits under the row at 1.1% opacity, like the existing PDF tab button. On iOS, a dialog may stay open over the new tab.
  • Windows. progress-windows.yml runs the launcher checks on this PR.

…eview; bump to 1.14.3

- Open hands a file to the host's default app only when it is an image,
  video, audio, PDF or text file, checked on the real file. Scripts, apps,
  SVG, HTML and folders copy their path; HTML always opens in Paseo.
- The paseo_progress agent tool refuses install-launcher. It is the only
  command that writes outside Progress's state folder and the chosen
  run-history folder.
- A page given any file git ignores gets a Content-Security-Policy that
  blocks every load and every script except Progress's Escape handler.
  Measured in Chromium 156: with scripts allowed, a page can still send data
  by navigating its frame or over WebRTC, so its scripts stay off.
- paseo-progress.cmd runs the Node that installed it by full path, and the
  launcher asks Paseo from Node's folder instead of the agent's.
…ress's page screen

Progress showed an HTML deliverable on a screen of its own and copied the
files the page loaded into it, which could hand a page a file git ignores.
That screen, the file copying and the server's HTML preview are gone.

Pressing an HTML deliverable, an HTML file in a folder deliverable, a
question attachment or a ticket's write-up now opens it in a Paseo tab, in
Paseo's built-in HTML preview. That preview runs the page's own scripts in a
sandboxed frame and blocks every load from the web. Plugins can only open a
tab through a Markdown link to a local file, so each page row holds one. In a
browser the link stays hidden and the row clicks it. On a phone it covers
the row, almost clear.

The deliverable add help, the agent tool and the skill now tell agents to
write self-contained HTML: CSS in the page, images as data URIs, nothing
from the web.
@stevecastaneda
stevecastaneda merged commit 23a7f5d into main Nov 7, 2026
3 checks passed
@stevecastaneda
stevecastaneda deleted the progress-1.14.3-blockers branch November 7, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant