Skip to content

chore(scaleway): the metadata API's five operations moved to their context variants #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephrobert merged 1 commit into from
Sep 25, 2026
Merged

chore(scaleway): the metadata API's five operations moved to their context variants #793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions coverage/scaleway-coverage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1818,35 +1818,35 @@
"status": "implemented"
},
{
"operation": "instance/v1/MetadataAPI.DeleteUserData",
"operation": "instance/v1/MetadataAPI.DeleteUserDataWithContext",
"product": "instance",
"reason": "the metadata service answers on the link-local address 169.254.42.42, from inside the machine, to a caller that carries no credentials",
"version": "v1",
"status": "declined"
},
{
"operation": "instance/v1/MetadataAPI.GetMetadata",
"operation": "instance/v1/MetadataAPI.GetMetadataWithContext",
"product": "instance",
"reason": "the metadata service answers on the link-local address 169.254.42.42, from inside the machine, to a caller that carries no credentials",
"version": "v1",
"status": "declined"
},
{
"operation": "instance/v1/MetadataAPI.GetUserData",
"operation": "instance/v1/MetadataAPI.GetUserDataWithContext",
"product": "instance",
"reason": "the metadata service answers on the link-local address 169.254.42.42, from inside the machine, to a caller that carries no credentials",
"version": "v1",
"status": "declined"
},
{
"operation": "instance/v1/MetadataAPI.ListUserData",
"operation": "instance/v1/MetadataAPI.ListUserDataWithContext",
"product": "instance",
"reason": "the metadata service answers on the link-local address 169.254.42.42, from inside the machine, to a caller that carries no credentials",
"version": "v1",
"status": "declined"
},
{
"operation": "instance/v1/MetadataAPI.SetUserData",
"operation": "instance/v1/MetadataAPI.SetUserDataWithContext",
"product": "instance",
"reason": "the metadata service answers on the link-local address 169.254.42.42, from inside the machine, to a caller that carries no credentials",
"version": "v1",
Expand Down
22 changes: 17 additions & 5 deletions internal/providers/scaleway/pack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,12 +873,24 @@ func (p *Pack) Declined() []emulator.Decline {
// and serving it would mean an HTTP listener inside every emulated
// machine. User data reaches the guest through the runtime instead,
// which is what cloud-init reads.
//
// The names moved on 2026-09-2x and the endpoints did not. Scaleway added a
// `WithContext` variant of each and turned the bare one into a deprecated
// wrapper — `GetMetadata()` is now `GetMetadataWithContext(ctx)` with a
// timeout around it, carrying a `//go:fix inline` directive.
//
// So the scan stopped counting the old spellings, and it is right to: a
// method that composes an exported one adds no endpoint, which is the rule
// that already keeps WaitForServer and ServerActionAndWait out. The five
// listed here are the ones that build a request today. Keeping the old
// names beside them would leave five orphan routes — a refusal naming
// something upstream no longer has, which is the drift report's own alarm.
emulator.Because("the metadata service answers on the link-local address 169.254.42.42, from inside the machine, to a caller that carries no credentials",
"instance/v1/MetadataAPI.GetMetadata",
"instance/v1/MetadataAPI.GetUserData",
"instance/v1/MetadataAPI.ListUserData",
"instance/v1/MetadataAPI.SetUserData",
"instance/v1/MetadataAPI.DeleteUserData"),
"instance/v1/MetadataAPI.GetMetadataWithContext",
"instance/v1/MetadataAPI.GetUserDataWithContext",
"instance/v1/MetadataAPI.ListUserDataWithContext",
"instance/v1/MetadataAPI.SetUserDataWithContext",
"instance/v1/MetadataAPI.DeleteUserDataWithContext"),

// IAM, everything except the SSH keys the pack serves.
//
Expand Down
Loading