chore(drift): triage the dedicated pools and the conversion catalogue - #786
Merged
Merged
Conversation
Five operations appeared in instance/v2alpha1 and nobody had decided about them, so drift:check exited 2 on every branch. Declined, in **two** entries rather than one, because they fail for different reasons and both survive a promotion of v2alpha1 to a stable instance/v2 — which the blanket alpha reason below them would not. **The four Dedicated Pool operations are the provider's fleet.** The SDK says it plainly: "List Dedicated Pools for an organization", "Instance types available in a Dedicated Pool and their technical details". A dedicated pool is physical capacity reserved for somebody, and this emulator has none. Answering would publish headroom a client could plan a migration onto, which is the refusal GetServerTypesAvailability already carries and docs/limits.md states. **ListServerCompatibleTypes is a missing measurement, not a missing fleet.** "List the Instance types that a given instance could be converted to" is a compatibility matrix — local volumes, architecture, generation — and corpus/ holds no recording of it across its 619 exchanges. The catalogue this pack serves is a small fixed table rather than Scaleway's, so an invented answer would have a client plan a resize the real API refuses. Neither is called by anything this project drives: zero occurrences in corpus/, for either subject. Assisted-by: Claude Code (claude-opus-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Five operations appeared in
instance/v2alpha1and nobody had decided about them, sodrift:checkexited 2 on every branch. #784 has been carrying them since 16 September.Declined, in two entries rather than one, because they fail for different reasons — and both survive a promotion of v2alpha1 to a stable
instance/v2, which the blanket alpha reason below them would not.The four Dedicated Pool operations are the provider's fleet
The SDK says it plainly: "List Dedicated Pools for an organization", "Instance types available in a Dedicated Pool and their technical details".
A dedicated pool is physical capacity reserved for somebody, and this emulator has none. Answering would publish headroom a client could plan a migration onto — the refusal
GetServerTypesAvailabilityalready carries, and whatdocs/limits.mdstates as policy.ListServerCompatibleTypesis a missing measurement, not a missing fleet"List the Instance types that a given instance could be converted to" is a compatibility matrix: local volumes, architecture, generation.
corpus/holds no recording of it across its 619 exchanges, and the catalogue this pack serves is a small fixed table rather than Scaleway's.An invented answer would have a client plan a resize the real API refuses. Same verdict as the pools, different reason, so a different entry.
Measured, not assumed
corpus/GetDedicatedPoolappeared upstreamListServerCompatibleTypesappeared upstreamOne thing worth knowing for the next drift
The issue's body still reads "The refreshed baseline is in the pull request tagged
chore/upstream-drift" and still lists four operations. Neither is a defect in the scan: the workflow posts updates as comments rather than editing the body, and the latest comment (01:47 this morning) carries all five correctly. The body is simply frozen at the day the issue was opened.The line about a pull request is now inaccurate, though, since #761 stopped the workflow from creating one — repository policy forbids Actions from opening pull requests. Worth a follow-up so the body points at the compare link instead; not folded in here, to keep this change to the triage.
Type of change
Checklist
Always
mise run checkpasses, andmise run prepushin full — which is what was red before thisinternal/corestill knows no providermise run testplanwas run. It asks forconformance:leg -- scw-clion a pack change; it was not played, deliberately: this change mounts no route and alters no handler. It adds five strings toDeclined()and the documentsdrift:updateregenerated from them. No response any client can observe differs before and after, so the leg would re-prove the previous commit.When a model wrote a substantive part of this
Assisted-by:trailer names the tool and the model versionmise run conformance, for the reason stated just abovescaleway-sdk-go'sapi/instance/v2alpha1/instance_sdk.go, read directly, along with the doc comments quoted in the reasonsWhen a route is added or changed
N/A — no route added or changed.
mise run drift:updatewas run andcoverage/is committed with the change, along with theREADME.mdanddocs/routes.mdit regenerated.When behaviour a client can observe changes
N/A — none does. A declined operation answered 501 before this change and answers 501 after; what changes is that the refusal now carries a reason.
When
.github/workflows/is touchedN/A.
When a machine runtime is involved
N/A.
Related issues
Triages what #784 reports.
🤖 Generated with Claude Code