Fixed the problem where #mail module method was not fired#14
Open
Fire-Dragon-DoL wants to merge 9 commits intostephenb:masterfrom
Open
Fixed the problem where #mail module method was not fired#14Fire-Dragon-DoL wants to merge 9 commits intostephenb:masterfrom
Fire-Dragon-DoL wants to merge 9 commits intostephenb:masterfrom
Conversation
…it didn't append sendgrid headers
…mail method completely hides the module method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the instance method ActionMailer::Base#mail takes precedence over SendGrid::ClassMethods#mail method, the module method was never run.
To fix this, I override #mail in the class_eval when module is included, moving the mail method from ClassMethods directly in here and adding at the end #send_grid_old_mail method call, which is just an alias for ActionMailer::Base#mail method.