feat(modbus): use poll() for Linux instead of select()#617
Open
fcntlcn wants to merge 1 commit intostephane:masterfrom
Open
feat(modbus): use poll() for Linux instead of select()#617fcntlcn wants to merge 1 commit intostephane:masterfrom
fcntlcn wants to merge 1 commit intostephane:masterfrom
Conversation
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get yourself added. |
Owner
|
After a quick look, it seems the tv struct could be replaced by a single integer var (ms). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1024 limitation of select() makes some problem these days. I think using poll() for *nix systems may be a better choice.