feat(PINE-28): E2E connection flow tests

[stepandel]

Summary

Comprehensive E2E tests for connection management across all providers.

Pinecone Tests (Active)

• Connection modal display and form validation
• Required field validation
• Error handling for invalid API keys
• Successful connection with valid credentials
• Collections/indexes display after connection
• Disconnect functionality
• Reconnection after disconnect
• Profile saving and loading
• Unreachable URL error handling

Qdrant/Weaviate Tests (Skipped)

• Skeleton tests with test.skip() and TODO comments
• Will be enabled when adapter system is integrated

Test Features

• Uses Docker test containers from docker-compose.test.yml
• Leverages existing e2e/electron.setup.ts helpers
• Auto-skips tests requiring real API keys when not available
• Comprehensive error path testing

Closes PINE-28

Summary by CodeRabbit

• Tests
  • Added comprehensive end-to-end test coverage for connection flows, including form validation, error handling, profile persistence, and provider reconnection scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

A comprehensive end-to-end Playwright test suite is introduced for the Electron app's Pinecone connection flow. The suite validates UI presence, form submission, API key validation, connection success/failure, profile persistence, and multi-provider scenarios through conditional test execution and helper utilities.

Changes

Cohort / File(s)	Summary
E2E Connection Flow Tests e2e/connection-flow.spec.ts	Adds 462 lines of Playwright test cases covering Electron app startup, connection form validation, IPC-based API communication, profile creation/persistence, and disconnect/reconnect cycles. Includes conditional tests for real Pinecone API keys, placeholder tests for Qdrant and Weaviate providers, and uses setup/teardown helpers (launchElectronApp, cleanupTestProfiles, closeElectronApp).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat(PINE-27): Setup Playwright E2E testing infrastructure #25: Introduces the test helper functions and IPC setup infrastructure (launchElectronApp, createPineconeTestProfile, cleanupTestProfiles) that this test suite directly depends on and exercises.

Poem

🐰 Connections tested, hop by hop,
Forms validated, errors stop,
Profiles persist through electron's grace,
E2E flows light up the place! 🚀

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding E2E connection flow tests for the Electron app with Pinecone provider support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/pine-28-connection-flow-tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Code Review

Issue Found: Missing Exports

The test file imports createQdrantTestProfile and createWeaviateTestProfile from ./electron.setup, but these functions are not exported from electron.setup.ts. This will cause a compilation/import error.

Location: e2e/connection-flow.spec.ts:1-9

Problematic code:

import {
  launchElectronApp,
  closeElectronApp,
  cleanupTestProfiles,
  createPineconeTestProfile,
  createQdrantTestProfile,
  createWeaviateTestProfile,
  type ElectronTestContext,
} from './electron.setup'

Suggested fix:

Since these tests are marked with test.skip() and are placeholders for future implementation, the simplest fix is to remove these unused imports for now and add them back when the adapter system is integrated:

import {
  launchElectronApp,
  closeElectronApp,
  cleanupTestProfiles,
  createPineconeTestProfile,
  type ElectronTestContext,
} from './electron.setup'

Alternatively, you can add stub implementations of these functions to electron.setup.ts if you prefer to keep the imports for documentation purposes.