fix(tsconfig.json): required for dist/types/stencil.core.d.ts to form…#83
Open
cge wants to merge 1 commit intostenciljs:mainfrom
Open
fix(tsconfig.json): required for dist/types/stencil.core.d.ts to form…#83cge wants to merge 1 commit intostenciljs:mainfrom
cge wants to merge 1 commit intostenciljs:mainfrom
Conversation
This was referenced Sep 16, 2019
Closed
|
Why did you close it, @cge? |
Author
|
Hi @kristof0425 , thanks for the comment. This PR was made during a quick feasibility study only and given the silence I imagined a better solution was in the works. I'll re-open since you've shown interest. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… on build
Currently
npm run builddoes not generatedist/types/stencil.core.d.ts. When wrapping a Stencil component library with React, this file is needed to avoidtsccompilation errors. Please see a related PR which will be made soon here: https://github.com/ionic-team/stencil-ds-react-template