Migrate transaction read path to use views

CHANGELOG.md

@@ -12,6 +12,8 @@
 ### Changed
 * `getTransactions` now scans at most 10,000 ledgers per request. On a sparse range a page can come back short — or even empty — while still carrying a `cursor`, so a response shorter than `limit` no longer implies end-of-data. Every response carries a `cursor`; to tell a sparse scan window from the tip, compare the cursor's ledger part against `latestLedger` and keep paging while it is below ([#908](https://github.com/stellar/stellar-rpc/pull/908)).
 * `getEvents` now rejects malformed contract IDs in filters with `-32602`: a `C…` string with a valid checksum but wrong-length payload used to decode and silently match nothing, and now errors under the SDK's stricter SEP-23 strkey parsing ([#908](https://github.com/stellar/stellar-rpc/pull/908)).
+* `getTransactions` now returns `-32603` (internal error) instead of `-32602` (invalid params) when the node cannot parse a transaction out of its own stored ledger meta in both rpcv1 and rpcv2. Because the request parameters are valid in that case, the previous error was misleading ([#962](https://github.com/stellar/stellar-rpc/pull/962)).
+* `getTransaction` and `getTransactions` now serve transactions with legacy `TransactionMeta` V0. This changes wire behavior for BOTH rpcv1 and rpcv2 (though in practice only a full-history node retains ledgers old enough to carry V0 meta). Such a transaction used to fail the request with `-32603` ("unsupported TransactionMeta version: 0"), and in `getTransactions` one V0 transaction failed the whole page. They are now returned like any other pre-Soroban transaction, with no events ([#962](https://github.com/stellar/stellar-rpc/pull/962)).
 
 ## [v28.0.1](https://github.com/stellar/stellar-rpc/compare/v28.0.0...v28.0.1)
 

cmd/stellar-rpc/internal/methods/get_events_test.go

@@ -146,16 +146,16 @@ func TestGetEvents(t *testing.T) {
 			})
 			require.NoError(t, err)
 			expected = append(expected, protocol.EventInfo{
-				EventType:                protocol.EventTypeContract,
-				Ledger:                   1,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
-				ID:                       id,
-				TopicXDR:                 []string{value},
-				ValueXDR:                 value,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(i).HexString(),
-				OpIndex:                  0,
-				TxIndex:                  uint32(i + 1),
+				EventType:       protocol.EventTypeContract,
+				Ledger:          1,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
+				ID:              id,
+				TopicXDR:        []string{value},
+				ValueXDR:        value,
+				TransactionHash: ledgerCloseMeta.TransactionHash(i).HexString(),
+				OpIndex:         0,
+				TxIndex:         uint32(i + 1),
 			})
 		}
 		cursor := protocol.MaxCursor
@@ -305,16 +305,16 @@ func TestGetEvents(t *testing.T) {
 		require.NoError(t, err)
 		expected := []protocol.EventInfo{
 			{
-				EventType:                protocol.EventTypeContract,
-				Ledger:                   1,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
-				ID:                       id,
-				TopicXDR:                 []string{counterXdr, value},
-				ValueXDR:                 value,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(4).HexString(),
-				TxIndex:                  5,
-				OpIndex:                  0,
+				EventType:       protocol.EventTypeContract,
+				Ledger:          1,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
+				ID:              id,
+				TopicXDR:        []string{counterXdr, value},
+				ValueXDR:        value,
+				TransactionHash: ledgerCloseMeta.TransactionHash(4).HexString(),
+				TxIndex:         5,
+				OpIndex:         0,
 			},
 		}
 
@@ -496,16 +496,16 @@ func TestGetEvents(t *testing.T) {
 		// flexible topic length matching
 		expected := []protocol.EventInfo{
 			{
-				EventType:                protocol.EventTypeContract,
-				Ledger:                   1,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
-				ID:                       id,
-				TopicXDR:                 []string{counterXdr, value, value, counterXdr},
-				ValueXDR:                 value,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(4).HexString(),
-				TxIndex:                  5,
-				OpIndex:                  0,
+				EventType:       protocol.EventTypeContract,
+				Ledger:          1,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
+				ID:              id,
+				TopicXDR:        []string{counterXdr, value, value, counterXdr},
+				ValueXDR:        value,
+				TransactionHash: ledgerCloseMeta.TransactionHash(4).HexString(),
+				TxIndex:         5,
+				OpIndex:         0,
 			},
 		}
 		require.NoError(t, err)
@@ -670,16 +670,16 @@ func TestGetEvents(t *testing.T) {
 		require.NoError(t, err)
 		expected := []protocol.EventInfo{
 			{
-				EventType:                protocol.EventTypeContract,
-				Ledger:                   1,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
-				ID:                       id,
-				TopicXDR:                 []string{counterXdr, value},
-				ValueXDR:                 value,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(3).HexString(),
-				TxIndex:                  4,
-				OpIndex:                  0,
+				EventType:       protocol.EventTypeContract,
+				Ledger:          1,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
+				ID:              id,
+				TopicXDR:        []string{counterXdr, value},
+				ValueXDR:        value,
+				TransactionHash: ledgerCloseMeta.TransactionHash(3).HexString(),
+				TxIndex:         4,
+				OpIndex:         0,
 			},
 		}
 		cursor := protocol.MaxCursor
@@ -758,16 +758,16 @@ func TestGetEvents(t *testing.T) {
 		id := protocol.Cursor{Ledger: 1, Tx: 1, Op: 0, Event: 1}.String()
 		expected := []protocol.EventInfo{
 			{
-				EventType:                protocol.EventTypeSystem,
-				Ledger:                   1,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
-				ID:                       id,
-				TopicXDR:                 []string{counterXdr},
-				ValueXDR:                 counterXdr,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(0).HexString(),
-				TxIndex:                  1,
-				OpIndex:                  0,
+				EventType:       protocol.EventTypeSystem,
+				Ledger:          1,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
+				ID:              id,
+				TopicXDR:        []string{counterXdr},
+				ValueXDR:        counterXdr,
+				TransactionHash: ledgerCloseMeta.TransactionHash(0).HexString(),
+				TxIndex:         1,
+				OpIndex:         0,
 			},
 		}
 		cursor := protocol.MaxCursor
@@ -842,16 +842,16 @@ func TestGetEvents(t *testing.T) {
 			value, err := xdr.MarshalBase64(txMeta[i].MustV3().SorobanMeta.Events[0].Body.MustV0().Data)
 			require.NoError(t, err)
 			expected = append(expected, protocol.EventInfo{
-				EventType:                protocol.EventTypeContract,
-				Ledger:                   1,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
-				ID:                       id,
-				TopicXDR:                 []string{value},
-				ValueXDR:                 value,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(i).HexString(),
-				TxIndex:                  uint32(i + 1),
-				OpIndex:                  0,
+				EventType:       protocol.EventTypeContract,
+				Ledger:          1,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      "CAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABSC4",
+				ID:              id,
+				TopicXDR:        []string{value},
+				ValueXDR:        value,
+				TransactionHash: ledgerCloseMeta.TransactionHash(i).HexString(),
+				TxIndex:         uint32(i + 1),
+				OpIndex:         0,
 			})
 		}
 		cursor := expected[len(expected)-1].ID
@@ -954,16 +954,16 @@ func TestGetEvents(t *testing.T) {
 			expectedXdr, err := xdr.MarshalBase64(xdr.ScVal{Type: xdr.ScValTypeScvSymbol, Sym: &symbols[i]})
 			require.NoError(t, err)
 			expected = append(expected, protocol.EventInfo{
-				EventType:                protocol.EventTypeContract,
-				Ledger:                   5,
-				LedgerClosedAt:           now.Format(time.RFC3339),
-				ContractID:               strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
-				ID:                       id,
-				TopicXDR:                 []string{counterXdr},
-				ValueXDR:                 expectedXdr,
-				TransactionHash:          ledgerCloseMeta.TransactionHash(i).HexString(),
-				TxIndex:                  uint32(i + 1),
-				OpIndex:                  0,
+				EventType:       protocol.EventTypeContract,
+				Ledger:          5,
+				LedgerClosedAt:  now.Format(time.RFC3339),
+				ContractID:      strkey.MustEncode(strkey.VersionByteContract, contractID[:]),
+				ID:              id,
+				TopicXDR:        []string{counterXdr},
+				ValueXDR:        expectedXdr,
+				TransactionHash: ledgerCloseMeta.TransactionHash(i).HexString(),
+				TxIndex:         uint32(i + 1),
+				OpIndex:         0,
 			})
 		}
 		cursor := expected[len(expected)-1].ID

cmd/stellar-rpc/internal/methods/get_transaction.go

@@ -2,7 +2,6 @@ package methods
 
 import (
 	"context"
-	"encoding/base64"
 	"encoding/hex"
 	"errors"
 	"fmt"
@@ -16,7 +15,6 @@ import (
 	"github.com/stellar/stellar-rpc/cmd/stellar-rpc/internal/store"
 )
 
-//nolint:funlen
 func GetTransaction(
 	ctx context.Context,
 	log *log.Entry,
@@ -63,70 +61,31 @@ func GetTransaction(
 		LatestLedgerCloseTime: storeRange.LastLedger.CloseTime,
 		OldestLedger:          storeRange.FirstLedger.Sequence,
 		OldestLedgerCloseTime: storeRange.FirstLedger.CloseTime,
-		TransactionDetails: protocol.TransactionDetails{
-			TransactionHash: request.Hash,
-		},
 	}
 
-	if errors.Is(getTxErr, store.ErrNoTransaction) {
+	switch {
+	case errors.Is(getTxErr, store.ErrNoTransaction):
 		response.Status = protocol.TransactionStatusNotFound
-		return response, nil
-	} else if getTxErr != nil {
+	case getTxErr != nil:
 		log.WithError(getTxErr).
 			WithField("hash", txHash).
 			Errorf("failed to fetch transaction")
 		return response, &jrpc2.Error{
 			Code:    jrpc2.InternalError,
 			Message: getTxErr.Error(),
 		}
-	}
-
-	response.ApplicationOrder = tx.ApplicationOrder
-	response.FeeBump = tx.FeeBump
-	response.Ledger = tx.Ledger.Sequence
-	response.LedgerCloseTime = tx.Ledger.CloseTime
-
-	switch request.Format {
-	case protocol.FormatJSON:
-		result, envelope, meta, convErr := transactionToJSON(tx)
-		if convErr != nil {
-			return response, &jrpc2.Error{
-				Code:    jrpc2.InternalError,
-				Message: convErr.Error(),
-			}
-		}
-		diagEvents, convErr := jsonifySlice(xdr.DiagnosticEvent{}, tx.Events)
-		if convErr != nil {
-			return response, &jrpc2.Error{
-				Code:    jrpc2.InternalError,
-				Message: convErr.Error(),
-			}
-		}
-
-		response.ResultJSON = result
-		response.EnvelopeJSON = envelope
-		response.ResultMetaJSON = meta
-		response.DiagnosticEventsJSON = diagEvents
-
-		response.Events, convErr = BuildEventsJSONFromTransaction(tx)
-		if convErr != nil {
+	default:
+		txInfo, ferr := transactionInfo(tx, request.Format)
+		if ferr != nil {
 			return response, &jrpc2.Error{
 				Code:    jrpc2.InternalError,
-				Message: convErr.Error(),
+				Message: ferr.Error(),
 			}
 		}
-	default:
-		response.ResultXDR = base64.StdEncoding.EncodeToString(tx.Result)
-		response.EnvelopeXDR = base64.StdEncoding.EncodeToString(tx.Envelope)
-		response.ResultMetaXDR = base64.StdEncoding.EncodeToString(tx.Meta)
-		response.DiagnosticEventsXDR = base64EncodeSlice(tx.Events)
-		response.Events = BuildEventsXDRFromTransaction(tx)
-	}
-
-	response.Status = protocol.TransactionStatusFailed
-	if tx.Successful {
-		response.Status = protocol.TransactionStatusSuccess
+		response.TransactionDetails = txInfo.TransactionDetails
+		response.LedgerCloseTime = txInfo.LedgerCloseTime
 	}
+	response.TransactionHash = request.Hash
 	return response, nil
 }