Repository navigation
Conversation
go-stellar-sdk replaced to sisuresh/go @ 50ebbb65; -prev now 28.0.1, -curr git-pinned to rs-soroban-env#1700 head with next; stellar-xdr git-pinned with cap_0084_muxed_contract.
Removed from protocols/rpc in the pinned go-stellar-sdk (#5995).
-prev now tracks core's protocol-29 stand-in (rs-soroban-env cb32250d, no crates.io release exists for it); -curr moves off the rs-soroban-env fork PR to its merged commit 169890d5 (protocol 30 by default, no `next` feature needed). stellar-xdr repinned to a9c9750e to match curr's own pin. go-stellar-sdk fork pin bumped to the PR #6015 head (still unmerged upstream).
Drops the oldest P27 leg per the one-stanza-per-protocol convention. No -vnext core artifact exists yet for CAP-0084, so the P30 leg's core image is left unset. Upgrade fixtures copied from P28 unchanged since CAP-0084 doesn't touch ConfigSettings.
The host window is now 29/30, so the P28 leg becomes P29 (with p29 upgrade fixtures copied from p28, as p30's were). Both legs use stellar-core 73f2bdd1's published artifacts. Host blocks declare their versions so check-dependencies.bash can find them.
stellar-core 73f2bdd1's packages are only in the unstable component.
Repin the host window to carry CAP-0087 (ML-DSA signature verification): -prev -> rs-soroban-env a721944b (core's actual p29 pin, fixing a stale cb32250d pin that had diverged from it), -curr -> f5a9fb79 (CAP-0087, also carries CAP-84's muxed contract addresses). Add cap_0087_ml_dsa to the shared stellar-xdr feature set. Repin go-stellar-sdk to go-stellar-sdk#6003's head (XDR_COMMIT ee040cd6, both CAP-84 and CAP-87 features). Regenerate the P30 upgrade fixtures with ContractCostType 86-94 (core's calibrated #1737 values, same as stellar-horizon#243's unlimited-config-v30.xdr) since core now rejects a v30 cost-params upgrade without them. Point CI's P29 leg at core master's published package and P30 at core#5455 built from source (no -vnext package exists with the CAP-87 pin yet).
Contributor
|
Closing in favor of #1050, which merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
-prev-> rs-soroban-enva721944b(core's real p29 pin, fixes a stale/divergedcb32250d),-curr->f5a9fb79(CAP-0087, also carries CAP-84). Addcap_0087_ml_dsato the shared stellar-xdr features.go-stellar-sdk#6003's head.ContractCostType86-94 (core's#1737values, same asstellar-horizon#243'sunlimited-config-v30.xdr) — core rejects a v30 cost-params upgrade missing them.#5455from source (no-vnextpackage carries the CAP-87 pin yet).Stacked on #1050 (CAP-0084) — shows its commits until that merges.
Upstream: go-stellar-sdk#6003, rs-soroban-env
f5a9fb79, stellar-core#5455.Supersedes #1026 (stale, predates the P29 compat work; that branch name was already taken by the old PR, hence
-ml-dsasuffix here).