Repository navigation
Protocol 30 Support - #253
Merged
Merged
Conversation
Brings in #230, #241, #246, #247, #248, #249, #250 and #251 from main. internal/ingest/core_lcm_test.go conflicted. #241 made filters.NewFilters take the network passphrase, and #237 moved the test code it changed into ingestCoreLCMFile, so the helper now passes coreTestNetworkPassphrase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBWddBqppX2FsWGbuaJ82g
Merge main into protocol-next Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBWddBqppX2FsWGbuaJ82g
Both integration legs and verify-range run stellar-core 30.0.0 (30.0.0-3642.0e49751aa), the protocol 29 leg included. That leg moves from jammy to noble like the protocol 30 leg. go-stellar-sdk moves to v0.8.0. Cuts the 30.0.0 changelog section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBWddBqppX2FsWGbuaJ82g
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
26 of 27 tasks
marwen-abid
reviewed
Oct 20, 2026
marwen-abid
approved these changes
Oct 20, 2026
marwen-abid
left a comment
marwen-abid
left a comment
Contributor
There was a problem hiding this comment.
Approved
- merge once RPC 30 image exists
30.0.0-220 is the stellar-rpc v30.0.0 release build (stellar/stellar-rpc@13e53516, bundling stellar-core 30.0.0). The protocol 29 leg runs it too, so the new RPC is checked at the previous protocol as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MBWddBqppX2FsWGbuaJ82g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Protocol 30 to
mainfor the 30.0.0 release. Part of the Protocol 30 GA release train (stellar/go-stellar-sdk#6028).This branch sits on top of
protocol-nextand goes straight intomain, so it carries all ofprotocol-next(#237, #252) plus one release commit:30.0.0-3642.0e49751aa). The protocol 29 leg checks the new core at protocol 29 and moves from jammy to noble, like the protocol 30 leg.30.0.0section.internal/ingest/...,internal/db2/...andinternal/actions/...pass locally against Postgres 16 on the same SDK code as v0.8.0.Not mergeable until one more commit: the protocol 30 leg skips the RPC tests and the protocol 29 leg still uses stellar-rpc 29.0.0. Both move to a stellar-rpc 30 image built from the stellar-rpc release once it exists.
Please merge with a merge commit, not squash or rebase, so
protocol-nextstays an ancestor ofmain.🤖 Generated with Claude Code
https://claude.ai/code/session_01MBWddBqppX2FsWGbuaJ82g