Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
🔵 Needs a closer look
It depends on an unreleased fork and introduces a breaking error-type change.
0 open findings
What changed in this PR
Switches rpcclient to the pinned Stellar experimental jrpc2 fork, updates dependencies, stabilizes the CRC32C test, and documents the error-type change.
Changes:
- Replaces upstream
jrpc2imports and dependency. - Updates module checksums and indirect dependencies.
- Computes CRC32C dynamically.
- Documents the breaking error-type change.
| File | Description |
|---|---|
support/datastore/gcs_test.go |
Computes CRC32C from generated compressed bytes. |
go.sum |
Updates dependency checksums. |
go.mod |
Switches module dependencies. |
clients/rpcclient/main.go |
Uses the forked client and HTTP channel. |
clients/rpcclient/main_test.go |
Updates the jrpc2 error-type import. |
CHANGELOG.md |
Documents the changed error type. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Note: This branch is made obsolete by stellar-rpc/pull/1037, which does the work of the jrpc2 fork in-tree.
What
Switches
clients/rpcclientfromcreachadair/jrpc2v1.2.0 to thestellar-experimental/jrpc2fork, pinned at4ada2aea(stellar-experimental/jrpc2#1, based on upstream v1.3.5). Only import paths change inmain.goandmain_test.go, and the client behaves the same:client.goandjhttp/channel.gomatch v1.3.5 apart from the module path.sync.WaitGroup.Gorewrite.Other changes:
go.mod: the fork replacescreachadair/jrpc2, andcreachadair/mdsmoves from v0.13.4 to v0.26.1. Thegoline stays at 1.25.0.CHANGELOG.md: a Breaking Changes entry, because errors from the client are now the fork's*jrpc2.Error. Callers matching them witherrors.Asmust change their import.Why
stellar/stellar-rpc#1037 moves stellar-rpc to the fork, whose bridge streams large results straight to the socket. A 3 MB result drops from 36 ms to 2.4 ms per call. The fork also lets #1060's memoized handlers return pre-rendered
json.RawMessagebodies.stellar-rpc's integration tests use this
rpcclient. While it stays on upstream, stellar-rpc carries both modules, anderrors.Asagainst the fork's*jrpc2.Errornever matches. #1037 pins a commit from this PR for that.Notes
🤖 Generated with Claude Code