fix: support exact npm release recovery - #27
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24bff3f6fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Keep this caller filename stable: npm trusted publishing authorizes it. | ||
| uses: stella/.github/.github/workflows/npm-independent-release.yml@b8c0884053fb8d4fb6ba157692189e0f1aae1785 # v1.6.0 | ||
| with: | ||
| artifact-run-id: ${{ inputs.artifact_run_id || '' }} |
There was a problem hiding this comment.
Require a source ref when resuming an artifact run
When a dispatcher supplies artifact_run_id but leaves the independently optional source_ref blank, the release downloads tarballs from the prior run while the pack checkout falls back to the current github.sha and the reusable workflow receives no matching source coordinate. If main has advanced since that run, recovery verifies different manifests/source from the selected artifacts, so it can fail or operate on the wrong release state. Reject this input combination at the workflow boundary, or derive the source SHA from the selected run.
AGENTS.md reference: AGENTS.md:L56-L56
Useful? React with 👍 / 👎.
Summary
Validation
git diff --checkCC on behalf of @jan-kubica
Summary by CodeRabbit
New Features
Bug Fixes