Skip to content

fix: grant release artifact access #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-kubica merged 2 commits into from
Aug 11, 2026
Merged

fix: grant release artifact access #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8769393
fix: grant release artifact access
jan-kubica Aug 11, 2026
93d72fb
test: guard release artifact permissions
jan-kubica Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
github.ref == 'refs/heads/main'
&& (github.event_name == 'push' || inputs.publish_to_npm)
permissions:
actions: read
contents: write
id-token: write
# Keep this caller filename stable: npm trusted publishing authorizes it.
Expand Down
20 changes: 19 additions & 1 deletion scripts/bun-lock-workspace-versions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,27 @@ describe("bun.lock workspace self-version synchronization", () => {
publishWorkflow.indexOf(" workflow_dispatch:"),
);

for (const packageName of ["typescript-config", "oxlint-config"]) {
for (const packageName of [
"typescript-config",
"oxlint-config",
"oxlint-plugin",
]) {
expect(pushTrigger).toContain(`packages/${packageName}/CHANGELOG.md`);
expect(pushTrigger).not.toContain(`packages/${packageName}/package.json`);
}
});

test("release caller can verify and download package artifacts", async () => {
const publishWorkflow = await Bun.file(
new URL("../.github/workflows/publish.yml", import.meta.url),
).text();
const releaseJob = publishWorkflow.slice(
publishWorkflow.indexOf(" release:"),
);

expect(releaseJob).toContain("actions: read");
expect(releaseJob.indexOf("actions: read")).toBeLessThan(
releaseJob.indexOf("uses: stella/.github/"),
);
});
});
Loading