feat: support direct and split TypeScript installs - #22
Conversation
|
Warning Review limit reached
Next review available in: 6 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe TypeScript configuration now supports direct TypeScript 7 and split TypeScript 6 compatibility installations. Package peer compatibility, policy tests, README guidance, and the release changeset reflect these layouts. ChangesTypeScript installation layouts
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b07f390eb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/typescript-config/toolchain.json`:
- Around line 13-18: Adopt the official TypeScript 6/7 alias contract across all
affected surfaces: in packages/typescript-config/toolchain.json, use
npm:`@typescript/typescript6`@6.0.2 as the compatibility specifier, retain
typescript as the install name, reconcile packageAlias, and set the peer range
to >=6.0.2 <8; update packages/typescript-config/package.json accordingly.
Update both fixture cases in packages/oxlint-config/src/toolchain-policy.test.ts
and the README.md toolchain documentation to represent both aliases and the
tsc6/tsc binary roles.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: dd18330d-a0c5-4abc-b11e-8c42c01ac728
📒 Files selected for processing (5)
.changeset/calm-tools-support.mdREADME.mdpackages/oxlint-config/src/toolchain-policy.test.tspackages/typescript-config/package.jsonpackages/typescript-config/toolchain.json
d8f03e8 to
2a8e81d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a8e81db1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| the blocker accepts TypeScript 7. The shared config's peer range accepts both | ||
| layouts; the compiler and typecheck command in each layout remain TypeScript 7. |
There was a problem hiding this comment.
For consumers selecting split-compatibility, the later “Recommended scripts” block still sets typecheck to tsc --noEmit (README.md:132-139). Because both the compatibility typescript package and the @typescript/native alias expose a tsc binary, that unqualified shim does not guarantee the TypeScript 7 compiler and may silently run TypeScript 6, despite this section promising that typechecking remains on TypeScript 7. Show the split command from toolchain.json in the scripts guidance or explicitly qualify the existing example as direct-only.
AGENTS.md reference: AGENTS.md:L156-L156
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
bun testbun run typecheckbun run lintbun run buildbun run publintbun run pack:dry-runCC on behalf of @jan-kubica
Summary by CodeRabbit
New Features
Documentation