chore: update dependencies and Rust tooling - #106
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe pull request adds a compile-time checked Rust builder for ChangesCore and tooling updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02b4e42f78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 295: Update the Hawk job before the rust:hawk run step to provision Bun
using oven-sh/setup-bun@0c5077e51419868618aeaa5fe8019c62421857d6 (# v2), or
replace the bun run rust:hawk invocation with its equivalent Cargo command.
In `@crates/core/src/lib.rs`:
- Around line 345-370: Add tests covering TextSearchOptions::builder() default
construction and representative field overrides, including regex_chunk_size and
enum-valued fields such as regex_artifact_policy, fuzzy_metric, and
overlap_strategy. Assert that unspecified fields retain the defaults defined in
TextSearchOptions and that explicitly supplied values are preserved.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cc2c74a8-6fd2-4c69-a4a2-49915aa0c0a7
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockbun.lockis excluded by!**/*.lock
📒 Files selected for processing (9)
.changeset/bright-search-tools.md.changeset/config.json.github/workflows/ci.ymlcrates/core/Cargo.tomlcrates/core/src/lib.rspackage.jsonprovenance/THIRD-PARTY-NOTICES.repo.txtprovenance/projects/root/THIRD-PARTY-NOTICES.txtprovenance/projects/root/sbom.cdx.json
📜 Review details
🧰 Additional context used
📓 Path-based instructions (2)
**/*
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*: Keep each pull request focused on one feature.
Add tests for new functionality.
Runbun testbefore submitting a pull request.
Files:
provenance/projects/root/THIRD-PARTY-NOTICES.txtprovenance/THIRD-PARTY-NOTICES.repo.txtcrates/core/src/lib.rscrates/core/Cargo.tomlprovenance/projects/root/sbom.cdx.jsonpackage.json
package.json
📄 CodeRabbit inference engine (AGENTS.md)
Keep dependency versions aligned with
@stll/aho-corasick,@stll/regex-set, and@stll/fuzzy-search.
Files:
package.json
🧠 Learnings (2)
📚 Learning: 2026-07-24T11:25:46.588Z
Learnt from: CR
Repo: stella/text-search PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-07-24T11:25:46.588Z
Learning: Applies to package.json : Keep dependency versions aligned with `stll/aho-corasick`, `stll/regex-set`, and `stll/fuzzy-search`.
Applied to files:
package.json.changeset/config.json
📚 Learning: 2026-07-24T11:25:49.484Z
Learnt from: CR
Repo: stella/text-search PR: 0
File: CONTRIBUTING.md:0-0
Timestamp: 2026-07-24T11:25:49.484Z
Learning: Applies to **/* : Run `bun test` before submitting a pull request.
Applied to files:
package.json
🔇 Additional comments (11)
crates/core/Cargo.toml (1)
11-11: LGTM!.changeset/bright-search-tools.md (1)
1-5: LGTM!.changeset/config.json (1)
2-9: LGTM!provenance/THIRD-PARTY-NOTICES.repo.txt (1)
9-9: LGTM!provenance/projects/root/THIRD-PARTY-NOTICES.txt (1)
10-10: LGTM!provenance/projects/root/sbom.cdx.json (1)
10-10: LGTM!Also applies to: 57-69
package.json (4)
47-47: LGTM!
65-80: 🗄️ Data Integrity & IntegrationVerify the
@stllpackage version alignment before merge.Compare the changed
@stll/*-wasmversions with the corresponding@stll/aho-corasick,@stll/regex-set, and@stll/fuzzy-searchversions in all package manifests. The supplied context does not show the reference versions, so this dependency contract is not established.As per coding guidelines: “Keep dependency versions aligned with
@stll/aho-corasick,@stll/regex-set, and@stll/fuzzy-search.”
Based on learnings: “Applies to package.json: Keep dependency versions aligned withstll/aho-corasick,stll/regex-set, andstll/fuzzy-search.”Sources: Coding guidelines, Learnings
65-80: 🗄️ Data Integrity & IntegrationKeep the Bun lockfile consistent with this manifest.
Confirm that the PR updates
bun.lockorbun.lockbfor these dependency changes..github/workflows/ci.ymlrunsbun install --frozen-lockfilein the Lint and Runtime jobs. A stale lockfile will fail those jobs before validation runs.
65-80: 📐 Maintainability & Code QualityRun the required Bun test command before submission.
Confirm that
bun testpasses after the dependency and lockfile updates.As per coding guidelines: “Run
bun testbefore submitting a pull request.”
Based on learnings: “Applies to **/*: Runbun testbefore submitting a pull request.”Sources: Coding guidelines, Learnings
.github/workflows/ci.yml (1)
258-260: LGTM!Also applies to: 272-284
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaf6c0abfe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Release impact
This requests a patch release of
@stll/text-search. The npm dependency range already accepts the next compatible fuzzy-search patch; the Rust core is pinned to the merged upstream revision.Validation
Bun lint, typecheck, tests, build, Bun/Node runtime smoke tests, version check, Changesets status; Cargo fmt, strict Clippy, workspace tests, WASI check; Hawk 0.1.12, actionlint, and provenance regeneration.