Skip to content

fix: trust runner CAs in CLA checks #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-kubica merged 1 commit into from
Aug 12, 2026
Merged

fix: trust runner CAs in CLA checks #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/cla.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import assert from "node:assert/strict";
import { readFile } from "node:fs/promises";
import test from "node:test";

const workflowUrl = new URL("./cla.yml", import.meta.url);

test("the Node 24 CLA client trusts the runner CA store", async () => {
const workflow = await readFile(workflowUrl, "utf8");
const claStep = workflow.match(
/uses: contributor-assistant\/github-action@[^\n]+\n(?<body>(?: {8,}.+\n)+)/u,
);

assert.ok(claStep?.groups?.["body"], "CLA Assistant step not found");
assert.match(
claStep.groups["body"],
/^ {10}NODE_OPTIONS: "--use-system-ca"$/mu,
);
});
4 changes: 4 additions & 0 deletions .github/workflows/cla.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ jobs:
uses: contributor-assistant/github-action@ca4a40a7d1004f18d9960b404b97e5f30a505a08 # v2.6.1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# This archived action declares Node 20, so GitHub now forces it onto
# Node 24. Use the runner trust store for intermittent proxied TLS
# chains; certificate verification remains enabled.
NODE_OPTIONS: "--use-system-ca"
PERSONAL_ACCESS_TOKEN: ${{ steps.app-token.outputs.token }}
with:
path-to-signatures: "signatures/cla.json"
Expand Down
Loading