Skip to content

fix: let release PR mutations finish #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-kubica merged 1 commit into from
Aug 11, 2026
Merged

fix: let release PR mutations finish #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/changeset-release-pr.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ const indexOf = (text) => {
return index;
};

test("version PR mutations use latest-run branch concurrency", () => {
test("version PR mutations finish under branch concurrency", () => {
assert.match(
workflow,
/concurrency:\n {6}group: changeset-release-pr-\$\{\{ github\.ref \}\}\n {6}cancel-in-progress: true/,
/concurrency:\n {6}group: changeset-release-pr-\$\{\{ github\.ref \}\}\n {6}cancel-in-progress: false/,
);
});

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changeset-release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
timeout-minutes: 15
concurrency:
group: changeset-release-pr-${{ github.ref }}
cancel-in-progress: true
cancel-in-progress: false
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,12 +252,12 @@ jobs:
```

The caller must provide `changeset`, `changeset:version`, and a `.changeset/config.json`.
The shared workflow serializes each target branch with latest-run concurrency and
skips write-capable steps when its trigger commit is no longer the branch head. A
current no-op run closes any stale version PR and deletes its generated branch, so
interrupted runs converge without a duplicate release PR. Callers may use matching
workflow-level concurrency to cancel obsolete setup work before the reusable job
starts.
The shared workflow serializes each target branch without interrupting an active
release mutation, and skips write-capable steps when its trigger commit is no longer
the branch head. A current no-op run closes any stale version PR and deletes its
generated branch, so queued runs converge without a duplicate release PR. Callers
should use matching workflow-level concurrency without cancellation; newer pushes
replace obsolete pending runs while the active mutation finishes.

For hybrid repositories, `changeset:version` must synchronize the selected package
version into every npm, Cargo manifest, Python, and central `VERSION` surface. With
Expand Down
Loading