Fetch details for a single charging session#47
Merged
Conversation
Contributor
Author
|
@claude review please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De gem kan nu de details van een enkele laadsessie ophalen via
GET /api/session/{id}. Onderdeel van stekker/backlog#1996: daar willen wesession.start_at/end_atin StekkerWeb vullen met de canonieke Zaptec-timestamps in plaats vanTime.currentop het moment dat wij het bericht verwerken.Wat er verandert
Nieuwe publieke method op de client:
session_endis nullable in de Zaptec-API — het endpoint werkt dus zowel voor lopende als afgesloten sessies. Voor lopende sessies issigned_sessionook nognil.Waarom een aparte
Session-klasseNaast de bestaande
Zaptec::ArchivedSession(uit/api/sessions/archived, alleen historische lijst-items) is dit een compactere representatie voor het single-session endpoint. De schema's overlappen deels maar de responses zijn niet identiek (SessionEndDataheeft minder velden dan het archived-session-model), dus geen shared parser.Naaste kanten
De caller in StekkerWeb gaat dit endpoint alleen bij session-transitions aanroepen (start / end), niet elke poll-tick — zie stekker/backlog#1996 voor het integratie-ontwerp.