fix(browser): gate manual-login profile setup#191
Merged
steipete merged 2 commits intoMay 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/build-docs-site.mjswithoxfmtso currentpnpm run format:checkpasses on upstream main.Why
A Claude Code MCP browser consult can resolve to manual-login mode with a private profile that has never been signed into ChatGPT. Before this change, Oracle could open that separate Chrome profile, wait for login until the MCP client timed out, and leave the caller with a generic timeout or closed-window error.
The intended path should be explicit: first run setup with
--browser-keep-browser, or use--browser-attach-runningto reuse an already signed-in Chrome.Tests
pnpm vitest run tests/browser/index.test.ts tests/mcp/consult.test.ts tests/browser/pageActions.test.tspnpm run format:checkpnpm run buildpnpm run checkpnpm testgit diff --checkSmoke
browser-login-setupguidance and no long Chrome wait.