Typechecks - #9
Draft
stefano-maggiolo wants to merge 8 commits into
Draft
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
stefano-maggiolo
force-pushed
the
typechecks
branch
2 times, most recently
from
June 16, 2021 14:21
367f8e4 to
30b164f
Compare
stefano-maggiolo
force-pushed
the
master
branch
3 times, most recently
from
December 22, 2021 08:12
36316a7 to
bc2a337
Compare
stefano-maggiolo
force-pushed
the
typechecks
branch
from
December 23, 2021 08:15
30b164f to
c41161b
Compare
Therefore, it need casting to be used as a range endpoint. Found with typechecking.
I didn't see anything worrying in the changelogs, but there's only one way to find out... have people try it.
- as_declarative() has been removed, but the substitution is essentially 1:1; - URL is an immutable namedtuple, so we can't just update one field; - apparently in 1.3 there was some auto-unpacking of results of queries with one field, which does not work anymore in 1.4; I think this is related to https://docs.sqlalchemy.org/en/14/changelog/migration_14.html#rowproxy-is-no-longer-a-proxy-is-now-called-row-and-behaves-like-an-enhanced-named-tuple; - custom types using TypeDecorator should now specify cache_ok = True to take advantage of the new caching of SQL statements.
Nit found thanks to pytype. If it is inside the try catch, python doesn't know those variables are defined in the except clause.
stefano-maggiolo
force-pushed
the
typechecks
branch
from
December 23, 2021 09:11
c41161b to
9c24768
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is