Repository navigation
Don't trigger __missing__ when resolving missing mapping members - #102
Merged
Merged
Conversation
JsonPointer.walk() indexed Mapping documents before checking whether the member exists. For mappings with a __missing__ hook such as collections.defaultdict, this invoked the factory, which mutated the document, bypassed the `default` of resolve_pointer() and let set_pointer() create intermediate members even with create=False. Check membership first for Mapping documents so absent members are reported as missing. Objects that only implement __getitem__ keep their custom indexing behaviour. Fixes #101 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PewzphetpXGTHDnZMZg2t2
|
coverage: 97.74% (+0.03%) from 97.714% — claude/pensive-cannon-kvs467 into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonPointer.walk() indexed Mapping documents before checking whether
the member exists. For mappings with a missing hook such as
collections.defaultdict, this invoked the factory, which mutated the
document, bypassed the
defaultof resolve_pointer() and letset_pointer() create intermediate members even with create=False.
Check membership first for Mapping documents so absent members are
reported as missing. Objects that only implement getitem keep
their custom indexing behaviour.
Fixes #101
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PewzphetpXGTHDnZMZg2t2