[Trip Editor] Add visit progress history parity#280
Merged
Conversation
Owner
Author
|
Pre-merge validation complete for PR #280. Scope confirmed:
Validation confirmed from the PR body and GitHub checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273
Summary
Data / DTO
visitProgress,placesById, andregionsByIddata already returned to the Trip Editor.Manage Visit Behavior
/User/Visit/Edit/{visitId}?returnUrl=...route.Validation Results
npm run buildpassed.npx playwright test --config=playwright.config.ts --listpassed, 75 tests.tripEditorVisitProgress.spec.tspassed, 9 tests.npm run test:e2e:trip-editorpassed, 74 passed / 1 skipped.dotnet buildpassed.dotnet test --filter TripEditorpassed, 158 tests.dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600passed with warnings only.window.confirm; remainingconfirm(...)matches are shared-dialog usages.git diff --check origin/main...HEADpassed.E2E Note
http://localhost:5012and Vite onhttp://localhost:5173, focused and full E2E passed.LOC Warning Decisions
ClientApps/trip-editor/src/visitProgress.css.ClientApps/trip-editor/src/styles.css,ClientApps/trip-editor/src/map/leafletAdapter.ts,Areas/Api/Controllers/TripEditorController.cs,tests/e2e/trip-editor/tripEditorRichNotes.spec.ts,ClientApps/trip-editor/src/components/MetadataEditor.vue, andtests/e2e/trip-editor/tripEditorAreaEditing.spec.ts.Artifact Hygiene
.local,playwright-report,test-results,screenshots,traces, browser profile paths, orwwwroot/vite/trip-editor.