Skip to content

[Trip Editor] Add visit progress history parity#280

Merged
stef-k merged 5 commits into
mainfrom
feature/trip-editor-visit-progress-history
May 14, 2026
Merged

[Trip Editor] Add visit progress history parity#280
stef-k merged 5 commits into
mainfrom
feature/trip-editor-visit-progress-history

Conversation

@stef-k
Copy link
Copy Markdown
Owner

@stef-k stef-k commented May 14, 2026

Closes #273

Summary

  • Adds a sidebar Visits action that opens a read-only in-editor visit progress/history surface.
  • Shows visit progress grouped with existing trip editor context, using the editor's loaded place and region lookup data.
  • Keeps visit management outside the Trip Editor surface.

Data / DTO

  • Uses existing visitProgress, placesById, and regionsById data already returned to the Trip Editor.
  • No backend, API, or DTO changes.

Manage Visit Behavior

  • Manage visit uses normal guarded navigation to the existing /User/Visit/Edit/{visitId}?returnUrl=... route.
  • No in-editor visit create/edit/delete CRUD was added.
  • No Visit mutation API calls were added.

Validation Results

  • npm run build passed.
  • npx playwright test --config=playwright.config.ts --list passed, 75 tests.
  • Focused tripEditorVisitProgress.spec.ts passed, 9 tests.
  • npm run test:e2e:trip-editor passed, 74 passed / 1 skipped.
  • dotnet build passed.
  • dotnet test --filter TripEditor passed, 158 tests.
  • dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600 passed with warnings only.
  • Confirm scans are clean for window.confirm; remaining confirm(...) matches are shared-dialog usages.
  • git diff --check origin/main...HEAD passed.

E2E Note

  • Initial focused run failed only because ASP.NET/Vite were not running.
  • After starting ASP.NET on http://localhost:5012 and Vite on http://localhost:5173, focused and full E2E passed.

LOC Warning Decisions

  • Current slice files stay below the 400 LOC warning threshold after splitting visit progress styling into ClientApps/trip-editor/src/visitProgress.css.
  • LOC checker warnings remain in existing/grandfathered files outside this slice: ClientApps/trip-editor/src/styles.css, ClientApps/trip-editor/src/map/leafletAdapter.ts, Areas/Api/Controllers/TripEditorController.cs, tests/e2e/trip-editor/tripEditorRichNotes.spec.ts, ClientApps/trip-editor/src/components/MetadataEditor.vue, and tests/e2e/trip-editor/tripEditorAreaEditing.spec.ts.
  • Warning accepted because this PR does not grow those files and the visit-progress implementation remains split by responsibility.

Artifact Hygiene

  • No tracked transient artifacts are present under .local, playwright-report, test-results, screenshots, traces, browser profile paths, or wwwroot/vite/trip-editor.

@stef-k
Copy link
Copy Markdown
Owner Author

stef-k commented May 14, 2026

Pre-merge validation complete for PR #280.

Scope confirmed:

  • Adds the Trip Editor visit progress/history read-only surface.
  • Uses existing Trip Editor read data for visit progress, places, and regions.
  • Leaves Visit mutation CRUD in the existing Visit workflow; no backend/API/DTO changes were made.

Validation confirmed from the PR body and GitHub checks:

  • GitHub Actions test check is terminal and passing.
  • npm run build passed.
  • npx playwright test --config=playwright.config.ts --list passed, 75 tests.
  • Focused tripEditorVisitProgress.spec.ts passed, 9 tests.
  • npm run test:e2e:trip-editor passed, 74 passed / 1 skipped after ASP.NET and Vite were started.
  • dotnet build passed.
  • dotnet test --filter TripEditor passed, 158 tests.
  • LOC policy check passed with warnings only in existing/grandfathered files outside this slice.
  • git diff --check origin/main...HEAD passed.
  • Confirm scans are clean for window.confirm; remaining confirm(...) matches are shared-dialog usages.
  • No tracked transient artifacts were found under .local, playwright-report, test-results, screenshots, traces, browser profile paths, or wwwroot/vite/trip-editor.

@stef-k stef-k merged commit 6d9073c into main May 14, 2026
1 check passed
@stef-k stef-k deleted the feature/trip-editor-visit-progress-history branch May 14, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Implementation][Trip Editor]: Visit progress and history UI parity

1 participant