Skip to content

feat: add doctest support for Uint64#12476

Merged
kgryte merged 4 commits into
stdlib-js:developfrom
impawstarlight:feature/uint64-doctest
Jun 3, 2026
Merged

feat: add doctest support for Uint64#12476
kgryte merged 4 commits into
stdlib-js:developfrom
impawstarlight:feature/uint64-doctest

Conversation

@impawstarlight
Copy link
Copy Markdown
Contributor

@impawstarlight impawstarlight commented Jun 3, 2026

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds doctesting support for Uint64 instances.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The following are the prerequisites that needs to be merged before this PR.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

No.

@stdlib-js/reviewers

@impawstarlight impawstarlight requested a review from a team June 3, 2026 01:02
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. labels Jun 3, 2026
@impawstarlight
Copy link
Copy Markdown
Contributor Author

impawstarlight commented Jun 3, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 3, 2026
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jun 3, 2026

/stdlib update-copyright-years

@impawstarlight, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 3, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 3, 2026

/stdlib update-copyright-years

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jun 3, 2026
@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 3, 2026
kgryte
kgryte reviewed Jun 3, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/_tools/doctest/create-annotation-value/lib/main.js Outdated
kgryte
kgryte reviewed Jun 3, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/_tools/doctest/compare-values/lib/main.js Outdated
@kgryte
Apply suggestions from code review
8025634 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 3, 2026

/stdlib merge

@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Jun 3, 2026

/stdlib update-copyright-years

@kgryte, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 3, 2026
@impawstarlight
Copy link
Copy Markdown
Contributor Author

impawstarlight commented Jun 3, 2026 •
edited
Loading

What about #12471 though? isUint64 is a direct dependency for this PR.
Edit: Ah I see, so this merge is not that merge 😅

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jun 3, 2026
@impawstarlight
Copy link
Copy Markdown
Contributor Author

impawstarlight commented Jun 3, 2026

@kgryte This is ready to merge now

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jun 3, 2026
@kgryte kgryte merged commit a69e22f into stdlib-js:develop Jun 3, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Tools Issue or pull request related to project tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@impawstarlight @stdlib-bot @kgryte