[6.x] Apply regenerate handle pattern for replicator sections#14745
Merged
Conversation
… that you don't accidentally change the handle when editing the name
Re-introduces handleSyncedWithDisplay, but sets it in edit() rather than created() so existing items always open with sync disabled. New items with placeholder handles still get the live sync UX. Also restores the empty- handle safety net in editConfirmed() for both files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
I noticed that while changing some set names – I inadvertently "deleted" the content too because it changed the handle at the same time. Changing the display name should not also change the handle name, and we should use the same "regenerate handle" pattern we use elsewhere.
What this PR Does
Before
After
How to Reproduce
DisplaynameDisplayname