Stop checkov from writing github_conf into the scanned repo#15
Merged
Conversation
The github_configuration framework dumps branch_protection_rules.json into the working directory. The container runs as root over a mounted workspace, so the file outlives the scan owned by root and the next actions/checkout — running as the runner's user — cannot delete it and fails every workflow on that runner. Skip the framework, and hand the workspace back to its owner after the scan as a guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/checkouthas been failing on the SportsID self-hosted runners:Checkov's
github_configurationframework calls the GitHub API (aGITHUB_TOKENis in the environment for PR comments) and dumpsgithub_conf/into the working directory. Our container runs as root over the mounted workspace, so the directory survives the scan owned by root — and the runner's user cannot delete it on the next checkout. That fails every workflow on that runner+repo, not only the scan: web-apps has had Security, PR Preview and CodeQL red since 13 July, and the scan that would have confirmed the jspdf/next fixes never ran.