Inherit workflow permissions instead of demanding them#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every scan in the sportsid-inc organization had been failing since the pull-request report shipped — and failing invisibly, with
startup_failureand not a single job.The reusable workflow declared
pull-requests: write. Declaring a permission demands it: an organization that grants workflows read-only access cannot satisfy it, so GitHub rejects the run before anything starts. 60 repositories stopped scanning and nothing said so.Permissions are now inherited from the caller. The scan always runs; where the caller's token may write to pull requests the report is posted as a comment, and where it may not, it still lands in the job summary — which the code already handled.