Fix the GitLab template: entrypoint and stage#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GitLab template had never been run against a real project. Migrating 54 repositories onto it surfaced two defects that broke every pipeline:
ENTRYPOINT ["cerberus"]the job dies instantly withcerberus: Unknown option '-c'. Clearing it (entrypoint: [""]) is the documented fix.stage: test, which only exists if the project happens to define it. Repositories with their ownstages:(build/deploy) failed at config parsing — the pipeline died before any job ran..postexists in every pipeline regardless, which is exactly why the DefectDojo template it replaces lived there.Verified on our GitLab: all 54 xpc/cg projects now produce a valid pipeline with a running scan job.