Skip to content

apollo_proc_macros: wrap crate in a non-proc-macro crate for reexports#13847

Open
dorimedini-starkware wants to merge 1 commit into04-21-apollo_infra_utils_re-export_tikv_jemallocator_for_downstream_macro_usagefrom
04-21-apollo_proc_macros_wrap_crate_in_a_non-proc-macro_crate_for_reexports
Open

apollo_proc_macros: wrap crate in a non-proc-macro crate for reexports#13847
dorimedini-starkware wants to merge 1 commit into04-21-apollo_infra_utils_re-export_tikv_jemallocator_for_downstream_macro_usagefrom
04-21-apollo_proc_macros_wrap_crate_in_a_non-proc-macro_crate_for_reexports

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on matanl-starkware and ShahakShama).


a discussion (no related file):
apollo_proc_macros_lib was just renamed from apollo_proc_macros (and crate Cargo.toml updated accordingly).
the new apollo_proc_macros crate is just a wrapper that reexports the lib contents, and will be used in later PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants