Optimize diagnostics flattening in get_all

[integraledelebesgue]

Summary

Collecting the diagnostic trees into a pre-allocated vector significantly reduces the amount of intermediate allocations.
Results in a huge gain of performance in CairoLS.

---

Type of change

Please check one:

• Bug fix (fixes incorrect behavior)
• New feature
• Performance improvement
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

[reviewable-StarkWare]

This change is 

[integraledelebesgue]

This change is part of the following stack:

• Optimize diagnostics flattening in get_all #9828 ◀
  • Skip modules without priv uses when computing unused imports diagnostics #9829
    • Replace singleton file overrides with granular inputs and views #9830
      • Replace singleton crate configs input with granular inputs and views #9831
        • Replace singleton plugin overrides with granular inputs and views #9835

_{Change managed by git-spice.}

[orizi]

@orizi made 6 comments.
Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on integraledelebesgue).

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 341 at r1 (raw file):

    }

    fn all_count(&self) -> usize {

move helpers to after usages.

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 341 at r1 (raw file):

    }

    fn all_count(&self) -> usize {

doc

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 345 at r1 (raw file):

    }

    pub fn extend_all_into(&self, out: &mut Vec<TEntry>) {

Suggestion:

    fn extend_all_into(&self, out: &mut Vec<TEntry>) {

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 345 at r1 (raw file):

    }

    pub fn extend_all_into(&self, out: &mut Vec<TEntry>) {

doc

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 345 at r1 (raw file):

    }

    pub fn extend_all_into(&self, out: &mut Vec<TEntry>) {

move helpers to after usages.

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 350 at r1 (raw file):

            subtree.extend_all_into(out);
        }
    }

if works (probably doesn't)
and than use extend directly.

Suggestion:

    pub fn iter<'a>(&'a self) -> impl Iterator<Item=&'a TEntry> {
        self.0.leaves.iter().chain(
            self.0.subtrees.iter().map(|subtree| subtree.iter()).flatten()
        )
    }

[integraledelebesgue]

@integraledelebesgue made 6 comments.
Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on orizi).

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 341 at r1 (raw file):

Previously, orizi wrote…

move helpers to after usages.

Done.

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 341 at r1 (raw file):

Previously, orizi wrote…

doc

Done.

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 345 at r1 (raw file):

Previously, orizi wrote…

doc

Done.

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 345 at r1 (raw file):

Previously, orizi wrote…

move helpers to after usages.

Done.

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 350 at r1 (raw file):

Previously, orizi wrote…

if works (probably doesn't)
and than use extend directly.

Doesn't work; rustc can't handle the generic return type in a recursive call for some reason

---

crates/cairo-lang-diagnostics/src/diagnostics.rs line 345 at r1 (raw file):

    }

    pub fn extend_all_into(&self, out: &mut Vec<TEntry>) {

Done.

[orizi]

@orizi reviewed 1 file and all commit messages, made 1 comment, and resolved 6 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on integraledelebesgue).

[piotmag769]

@piotmag769 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on integraledelebesgue).