Skip to content

Fix: issue 2030 - IllegalArgumentException when using findAndRerank without specifying rerankOn - #2578

Open
sl-at-ibm wants to merge 3 commits into
mainfrom
SL-issue2030-missingRerankOnValidation
Open

Fix: issue 2030 - IllegalArgumentException when using findAndRerank without specifying rerankOn#2578
sl-at-ibm wants to merge 3 commits into
mainfrom
SL-issue2030-missingRerankOnValidation

Conversation

@sl-at-ibm

Copy link
Copy Markdown
Contributor

What this PR does:

Until now, there are conditions where a call to findAndRerank without supplying rerankOn results in a naked "unexpected server error" / "illegal argument exception". This PR replaces those with a clean error belonging to the errors.yaml taxonomy.

Which issue(s) this PR fixes:
Fixes #2030.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • [n/a] Documentation added/updated
  • [?] CLA Signed: DataStax CLA

@sl-at-ibm
sl-at-ibm requested a review from a team as a code owner September 3, 2026 16:53
@sl-at-ibm
sl-at-ibm requested review from a team and removed request for a team September 3, 2026 16:54
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📈 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 53.40%
This PR 53.42%
Delta 🟢 +0.01%
✅ Coverage improved!

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Overall Project 53.42% 🍏
Files changed 100% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankOperationBuilder.java 83.45% 🍏

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 71.45%
This PR 71.45%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (dse69-it)

Overall Project 71.45% 🍏
Files changed 60% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankOperationBuilder.java 84.82% -0.55%

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

📈 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.76%
This PR 72.77%
Delta 🟢 +0.00%
✅ Coverage improved!

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage Report (hcd-it)

Overall Project 72.77% 🍏
Files changed 60% 🍏

File Coverage
RequestException.java 100% 🍏
FindAndRerankOperationBuilder.java 90.7% -0.55%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IllegalArgumentException when using findAndRerank-BYO vector but not specifying rerankOn

1 participant