Handle DELETE method in ReadSignals

[bencroker]

Based on ADR changes in starfederation/datastar#1146.

Please merge only with the release of the next version of Datastar.

[bencroker]

@JeremS is there a reason you named the function get-signals rather than read-signals, as per the ADR?

[JeremS]

Hey @bencroker,

Thanks for the PR. Do I need to merge it when there is a datastar RC9?

I can't recall if I just didn't follow the ADR at the time or if I already had a rationale when I named the get-signals function. With that said, we have several JSON libraries in Clojure. Since I didn't want to depend on any one of them (and impose it on a user) get-signals does not read the signals, it just return either a string or an input stream. It's up to the users to bring its their own JSON parsing. In this situation I wouldn't rename that function read-signals, it might have been better to name it get-signals-raw though.

Cheers,

[bencroker]

Do I need to merge it when there is a datastar RC9?

Merge whenever you want, provided you don’t release until the next version is out, which should be 1.0.0.

Thanks for clarifying the naming of get-signals, that can probably just stay as is.