Repository navigation
v2: split timestamps are days, recorded as dates in the manifest - #168
Merged
Merged
Conversation
Relational Transformer's preprocessor reads val_timestamp as a %Y-%m-%d date and panicked on the full quantile times v2 wrote. split_timestamps now returns the midnight before each quantile, and the manifest records a midnight as a date, as the published corpus does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the RT README's preprocessing on a v2 database, on the ILC cluster with relational-transformer 1.11.0, panicked:
relational-transformer's preprocessor (
rustler/src/pre.rs) readsval_timestampas a%Y-%m-%ddate. v2 wrote the exact quantile time, which is valid relbench but not readable by relational-transformer. The publishedstanford-star/plurelcorpus records dates, for exampleval_timestamp: '2017-12-27'.split_timestampsreturns the midnight before each quantile. The split moves by less than a day.write_databaserecords a midnight as a date, any other time in full, and a static database'sNaTas before.Draws and fingerprints do not move. Lint, pyright, 362 tests, README blocks and recipes pass. The new test checks the manifest records both split days as dates.
Checked end to end on the cluster at 45c6ebc:
scripts/synthetic_gen.pywroteplurel-0(20 tables, 112,484 rows) withval_timestampas a date. The RT README'sone(...)block, run verbatim, then completed:val_timestamp;meta.json,nodes.rkyv,offsets.rkyv,p2f_adj.rkyv, …).