Repository navigation
v2: fixes from the review before merging into main - #166
Merged
Merged
Conversation
kvignesh1420
force-pushed
the
v2-review-fixes
branch
2 times, most recently
from
November 16, 2026 22:52
c916152 to
d6e3fae
Compare
A static table may not point at events; categorical levels are strings; TablePrior columns read distinct slots; structured missingness blanks at its rate; a tiny autocorrelation is its noise; blanks keep a ByLevel column's values; ranged causes draw in key order; a negated shaped Range mirrors its shape; clearer errors for zero-weight edge families and Derived shapes; realize handles given positions into a counted table.
kvignesh1420
force-pushed
the
v2-review-fixes
branch
from
November 16, 2026 22:53
d6e3fae to
4784623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eleven bugs found reviewing v2 before it merges into
main, each confirmed with a repro, fixed and covered by a test.Breaking
Schemaraises). Its rows were kept at every time cut while pointing at events the cut drops (24 of 100 rows in the repro).SchemaPriornever built such schemas.Categorical((1, 2, 3))sampled but could not be written to parquet.Moves draws (fingerprints updated for darwin-arm64 and linux X86_V4; X86_V3 still holds the old digests)
TablePriorcolumns read distinct slots. Before, 45 of 200 default tables had columns that were relabelled copies of others, which leaks a target.missing_by, instead of a two-class node whose logit bias ran 1.7× over its rate at the median (now 1.00×).SchemaPriorseed 1355 failed with'n3' produced non-finite values.{"a": r, "b": r}and{"b": r, "a": r}draw the same.Errors and fixes that move no draws
Rangemirrors its shape.TablePriorwith zero weight on every family that fits any widths raises when built.Derivedfunction that returns other than one value per row raises aValueErrorinstead of anIndexError.realizehandles a key with given positions into a counted table (wasKeyError).missing_bymay name a one-dimensionalHiddennode.Lint, pyright, 361 tests, README blocks and recipes pass locally. 300 fresh
SchemaPriordatabases (seeds 1200–1499), written and checked: positional keys, no dangling keys, sorted times, no child before its parent, no infinities.