Make colors RGB again#36
Open
JasperHorn wants to merge 1 commit into
Open
Conversation
The hardware never considered the lights to be in GRB order. However, there was something else going on. Basically, the library is written to always allow you to specify colors in RGB order, but it can then write those colors to the lights in different orders (mainly RGB or GRB) and for some reason, by default it assumes your LEDs take the colors in GRB order. As such, it was rewriting the RGB colors to GRB format, even though the LEDs actually took them in RGB order, which made the colors wrong. Writing the colors as GRB is the opposite of this, so it undoes the change, making it seem that's the right way to specify the colors. By just telling the library that the LEDs are taking the colors in RGB order, you can specify the colors the way you normally do: RGB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardware never considered the lights to be in GRB order. However,
there was something else going on. Basically, the library is written to
always allow you to specify colors in RGB order, but it can then write
those colors to the lights in different orders (mainly RGB or GRB) and
for some reason, by default it assumes your LEDs take the colors in GRB
order.
As such, it was rewriting the RGB colors to GRB format, even though the
LEDs actually took them in RGB order, which made the colors wrong.
Writing the colors as GRB is the opposite of this, so it undoes the
change, making it seem that's the right way to specify the colors.
By just telling the library that the LEDs are taking the colors in RGB
order, you can specify the colors the way you normally do: RGB.