Skip to content

Reorganization and encapsulation of the main program#10

Open
pikuch wants to merge 11 commits into
standupmaths:mainfrom
pikuch:main
Open

Reorganization and encapsulation of the main program#10
pikuch wants to merge 11 commits into
standupmaths:mainfrom
pikuch:main

Conversation

@pikuch

@pikuch pikuch commented Dec 25, 2020

Copy link
Copy Markdown

It makes functions take a tree ( XmasTree or VirtualXmasTree) as an argument and use it to create patterns.

@oliverdunk

Copy link
Copy Markdown
Member

Hey @pikuch! Matt asked me to help with maintaining this repository, so I've been thinking about how to handle PRs like this. It's a tough one... your improvements are really nice, but it also changes the code significantly - and part of the purpose of this repo is to document the original code from the video.

I've added some thoughts to the README about how to structure the code here going forward.

With that in mind, would you be open to adding your wave effect to the examples folder, and then linking to the rest of your work under the "Further Work" section of the README? I think that's a sensible way forward - let me know if you agree.

@pikuch

pikuch commented Jan 11, 2021

Copy link
Copy Markdown
Author

Hey @pikuch! Matt asked me to help with maintaining this repository, so I've been thinking about how to handle PRs like this. It's a tough one... your improvements are really nice, but it also changes the code significantly - and part of the purpose of this repo is to document the original code from the video.

I've added some thoughts to the README about how to structure the code here going forward.

With that in mind, would you be open to adding your wave effect to the examples folder, and then linking to the rest of your work under the "Further Work" section of the README? I think that's a sensible way forward - let me know if you agree.

Hello! I realize my rewrite is quite drastic.

Feel free to use any of the code, including adding the wave effect to the examples folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants