Add public dimmedNodeIds and highlightedNodeIds props with union merge and fix NodeRenderer fade - #62
Open
fayekelmith wants to merge 1 commit into
Conversation
…props with union merge and fix NodeRenderer fade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<SystemCanvas>:dimmedNodeIds?: Set<string>andhighlightedNodeIds?: Set<string>, driven by the host application's own state (external search, filter, or agent-driven focus).unionIdSetshelper (exported for unit tests only).style.opacity/transitionon the node<g>permanently, which shadowed the SVG presentation attribute and froze dim/undim flips. Inline styles are now cleared after the mount fade (with timer cleanup on exit/unmount), mirrored after Viewport'striggerFadepattern.SystemCanvas.emphasis.test.tsx, 20 tests) with an inline jsdom harness (ResizeObserver + SVGSVGElement stubs).Testing
npm run typecheck— cleancd packages/react && npx vitest run src/components/__tests__/SystemCanvas.emphasis.test.tsx— 20/20 passing