bifrost: enforce_budgets config field -> BIFROST_PLUGIN_ENFORCE_BUDGETS - #760
Merged
Merged
Conversation
Mirrors enforce_macaroons: Option<bool> on BifrostImage, None ⇒ no env var ⇒ the image's config.json value stands; skip_serializing_if keeps persisted state unchanged. The gateway (stakgraph#1684) only honours it alongside enforce_macaroons — rollout is macaroons first, then budgets after watching the 'budget shadow' log lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #757 (base is
bifrost-enforce-macaroons; retarget tomasteronce that merges).Adds
enforce_budgets: Option<bool>toBifrostImage, emitted asBIFROST_PLUGIN_ENFORCE_BUDGETS=<bool>when set. Same contract asenforce_macaroons:None(default, and what existing persisted state loads as) ⇒ no env var ⇒ the gateway image'sconfig.jsonvalue stands (shadow).skip_serializing_ifkeeps the key out of persisted JSON when unset.getenv().Gateway side: stakwork/stakgraph#1684. The plugin only honours
enforce_budgetswhenenforce_macaroonsis also on (budgets would otherwise be bypassable by dropping the macaroon), so the intended sequence per swarm is macaroons → watchauth: budget shadowlines → budgets.Tests: emitted when set (true/false, independent of the macaroons knob), absent when unset, serde round-trip.
cargo test --lib images::bifrost: 16 passed.