Skip to content

fix: use cross-platform path assertions in config tests #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahmedhesham6 merged 3 commits into from
Jan 13, 2026
Merged

fix: use cross-platform path assertions in config tests #31

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36336bf
fix: use cross-platform path assertions in config tests
ahmedhesham6 Jan 12, 2026
8d4e271
lint
ahmedhesham6 Jan 12, 2026
c10fa12
Add Path to config tests module
ahmedhesham6 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions apps/cli/src/commands/core/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ impl Config {
/// Priority:
/// 1. Explicit scope flag
/// 2. Project config default_scope
/// 3. Global config default_scope
/// 3. Global config default_scope
/// 4. Hardcoded default: Global
pub fn effective_scope(&self, explicit_scope: Option<Scope>) -> Scope {
explicit_scope
Expand Down Expand Up @@ -481,6 +481,7 @@ impl Config {
#[cfg(test)]
mod tests {
use super::*;
use std::path::Path;

#[test]
fn test_default_config_has_builtin_agents() {
Expand Down Expand Up @@ -620,7 +621,7 @@ project_skills_dir = ".custom/skills"
let result = config
.resolve_skills_dir(Scope::Global, None, Some("~/custom/path"))
.unwrap();
assert!(result.to_string_lossy().contains("custom/path"));
assert!(result.ends_with(Path::new("custom").join("path")));

// Even with project scope, explicit dir wins
let result = config
Expand All @@ -637,7 +638,7 @@ project_skills_dir = ".custom/skills"
let result = config
.resolve_skills_dir(Scope::Global, Some("claude-code"), None)
.unwrap();
assert!(result.to_string_lossy().contains(".claude/skills"));
assert!(result.ends_with(Path::new(".claude").join("skills")));
}

#[test]
Expand All @@ -649,7 +650,7 @@ project_skills_dir = ".custom/skills"
let result = config
.resolve_skills_dir(Scope::Global, None, None)
.unwrap();
assert!(result.to_string_lossy().contains(".cursor/skills"));
assert!(result.ends_with(Path::new(".cursor").join("skills")));
}

#[test]
Expand All @@ -660,7 +661,7 @@ project_skills_dir = ".custom/skills"
let result = config
.resolve_skills_dir(Scope::Global, None, None)
.unwrap();
assert!(result.to_string_lossy().contains(".agents/skills"));
assert!(result.ends_with(Path::new(".agents").join("skills")));
}

#[test]
Expand All @@ -672,7 +673,7 @@ project_skills_dir = ".custom/skills"
#[test]
fn test_default_skills_dir() {
let dir = Config::default_skills_dir();
assert!(dir.to_string_lossy().contains(".agents/skills"));
assert!(dir.ends_with(Path::new(".agents").join("skills")));
}

#[test]
Expand Down