feat: ledger live usde banner#385
Merged
petar-omni merged 1 commit intomainfrom Jun 6, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 92e6bf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petar-omni
force-pushed
the
feat/usde-ll-banner
branch
from
7a905bc to
92e6bf1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a promotional banner prompting Ledger Live users with zero USDe balance to swap and earn.
- Introduces a new translation key for the USDe banner.
- Implements new styles and conditional rendering logic in the SelectTokenSection component.
- Adds an
isUSDeTokenhelper and aBalanceicon component.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| translations.json | Adds usde_banner translation under select_token |
| styles.css.ts | Defines styles for the bottom banner (bottomBanner, bottomBannerText, bottomBannerBottomRadius) |
| index.tsx | Implements showBottomUSDeBanner logic and renders the banner in SelectTokenSection |
| tokens.ts | Adds isUSDeToken utility to detect the USDe token |
| balance.tsx | Creates a new Balance SVG icon component |
| package.json | Bumps pnpm to 10.11.1 |
| .changeset/orange-snakes-stay.md | Records a patch release for the new feature |
Comments suppressed due to low confidence (2)
packages/widget/src/pages/details/earn-page/components/select-token-section/index.tsx:65
- This new conditional (
showBottomUSDeBanner) drives UI behavior; consider adding unit or component tests to verify the banner appears only for zero USDe balances on Ledger Live.
const showBottomUSDeBanner = Maybe.fromRecord({
packages/widget/src/pages/details/earn-page/components/select-token-section/styles.css.ts:8
- [nitpick] The name
bottomBannerBottomRadiusis a bit unclear; it might be more descriptive to name itbannerNoBottomRadiusorbannerFlatBottomCorners.
export const bottomBannerBottomRadius = style({
Philippoes
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Changed
Description of the modifications made to existing functionality, feature, or content in this pull request. This could include changes to code, CI, documentation, etc.