fix(spore): set TS_ADVERTISE_TAGS for golink OAuth auth#448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream
tailscale/golinkdefaults--advertise-tagsto$TS_ADVERTISE_TAGS(empty if unset), whereas the previous fork (apoxy-dev/golink) hardcodedtag:golinkas the default. With a wiped tsnet state and an OAuth client secret as the auth key, tsnet rejects authentication unless at least one tag is advertised.Sets
TS_ADVERTISE_TAGS=tag:golinkin the golink systemd service environment so OAuth auth keys work without patching the binary.Test plan
systemctl status golinkon spore showsactive (running)go.note-iwato.ts.netis reachable on the tailnet🤖 Generated with Claude Code