Skip to content

Migrate container client to moby/moby modules #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdimitrov merged 1 commit into from
Jun 3, 2026
+360 −330
Merged

Migrate container client to moby/moby modules #5420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions .github/workflows/security-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,23 +56,8 @@ jobs:

- name: Check for vulnerabilities (with exclusions)
run: |
# Ignored vulnerabilities with justification:
# GO-2026-4514: buger/jsonparser Delete function DoS via malformed JSON (CVE-2025-54410)
# Indirect dependency via mcp-go, invopop/jsonschema, wk8/go-ordered-map.
# The vulnerability is in the Delete function which is not called by ToolHive
# or any of its dependencies. No fixed version exists yet (all versions affected).
# GO-2026-4883: Off-by-one error in Moby plugin privilege validation (CVE-2026-33997)
# Affects the Docker daemon's plugin privilege handling code. ToolHive only uses
# the Docker client SDK to manage containers, not the daemon plugin subsystem.
# No fixed version exists for github.com/docker/docker; fix is only in
# github.com/moby/moby/v2 v2.0.0-beta.8+ which is not yet available as a
# docker/docker release.
# GO-2026-4887: AuthZ plugin bypass with oversized request bodies (CVE-2026-34040)
# Affects the Docker daemon's AuthZ plugin mechanism. ToolHive only uses the
# Docker client SDK and does not run or configure AuthZ plugins. No fixed version
# exists for github.com/docker/docker; fix is only in github.com/moby/moby/v2
# v2.0.0-beta.8+ which is not yet available as a docker/docker release.
IGNORED_VULNS="GO-2026-4514 GO-2026-4883 GO-2026-4887"
# Ignored vulnerabilities with justification: none currently.
IGNORED_VULNS=""

# Show the raw output for debugging
echo "::group::govulncheck raw output"
Expand Down
6 changes: 3 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ require (
github.com/charmbracelet/x/ansi v0.11.7
github.com/containerd/errdefs v1.0.0
github.com/coreos/go-oidc/v3 v3.18.0
github.com/docker/docker v28.5.2+incompatible
github.com/docker/go-connections v0.7.0
github.com/docker/docker v28.5.2+incompatible // indirect
github.com/docker/go-connections v0.7.0 // indirect
github.com/evanphx/json-patch/v5 v5.9.11
github.com/go-chi/chi/v5 v5.2.5
github.com/go-git/go-billy/v5 v5.9.0
Expand Down Expand Up @@ -208,7 +208,7 @@ require (
github.com/mfridman/interpolate v0.0.2 // indirect
github.com/mitchellh/go-homedir v1.1.0 // indirect
github.com/moby/go-archive v0.1.0 // indirect
github.com/moby/moby/api v1.54.2 // indirect
github.com/moby/moby/api v1.54.2
github.com/moby/patternmatcher v0.6.0 // indirect
github.com/moby/spdystream v0.5.1 // indirect
github.com/moby/sys/sequential v0.6.0 // indirect
Expand Down
Loading
Loading