Skip to content

chore: improve .dockerignore and move mock dependency to devDependencies#484

Open
peppescg wants to merge 1 commit intomainfrom
chore/improve-dockerignore-and-deps
Open

chore: improve .dockerignore and move mock dependency to devDependencies#484
peppescg wants to merge 1 commit intomainfrom
chore/improve-dockerignore-and-deps

Conversation

@peppescg
Copy link
Copy Markdown
Collaborator

@peppescg peppescg commented Apr 2, 2026

Summary

  • Improve .dockerignore to exclude dev/test files from Docker build context (tsconfig.tsbuildinfo, tests/, scripts/, dev-auth/, mocks/, etc.)
  • Move json-schema-faker from dependencies to devDependencies — it's only used in src/mocks/mocker.ts for test fixture generation

Impact

  • Reduces Docker build context size by excluding unnecessary files
  • Removes ~50KB from production bundle by not shipping mock-only dependency

Test plan

  • pnpm build succeeds
  • pnpm test passes
  • Docker build succeeds
  • json-schema-faker still works in tests (imported from mocks only)

🤖 Generated with Claude Code

…ncies

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 2, 2026 17:30
@github-actions github-actions bot added the size/XS Extra small PR: < 100 lines changed label Apr 2, 2026
@peppescg peppescg self-assigned this Apr 2, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces production build footprint by (1) tightening the Docker build context via .dockerignore, and (2) ensuring mock-only tooling (json-schema-faker) is not shipped as a runtime dependency.

Changes:

  • Expanded .dockerignore to exclude build artifacts and dev/test-only directories/files from the Docker build context.
  • Moved json-schema-faker from dependencies to devDependencies (used only under src/mocks/).
  • Updated pnpm-lock.yaml to reflect the dependency move.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
.dockerignore Excludes dev/test folders and build/test artifacts from Docker context to speed up builds and reduce context size.
package.json Moves json-schema-faker to devDependencies to avoid shipping it in production installs/bundles.
pnpm-lock.yaml Lockfile updated so json-schema-faker is recorded under dev dependencies.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Extra small PR: < 100 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants