chore: improve .dockerignore and move mock dependency to devDependencies#484
Open
chore: improve .dockerignore and move mock dependency to devDependencies#484
Conversation
…ncies Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces production build footprint by (1) tightening the Docker build context via .dockerignore, and (2) ensuring mock-only tooling (json-schema-faker) is not shipped as a runtime dependency.
Changes:
- Expanded
.dockerignoreto exclude build artifacts and dev/test-only directories/files from the Docker build context. - Moved
json-schema-fakerfromdependenciestodevDependencies(used only undersrc/mocks/). - Updated
pnpm-lock.yamlto reflect the dependency move.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.dockerignore |
Excludes dev/test folders and build/test artifacts from Docker context to speed up builds and reduce context size. |
package.json |
Moves json-schema-faker to devDependencies to avoid shipping it in production installs/bundles. |
pnpm-lock.yaml |
Lockfile updated so json-schema-faker is recorded under dev dependencies. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.dockerignoreto exclude dev/test files from Docker build context (tsconfig.tsbuildinfo, tests/, scripts/, dev-auth/, mocks/, etc.)json-schema-fakerfromdependenciestodevDependencies— it's only used insrc/mocks/mocker.tsfor test fixture generationImpact
Test plan
pnpm buildsucceedspnpm testpassesjson-schema-fakerstill works in tests (imported from mocks only)🤖 Generated with Claude Code