Repository navigation
feat(player): marquee current program titles - #750
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_12c83e64-de72-4aa9-9ac7-4c7d84d85380) |
Contributor
Documentation previewThe documentation preview has been deployed for this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Note
Low Risk
Player list UI-only change with no auth, data, or API impact; animation is gated by reduced-motion and cleaned up on unmount.
Overview
For the currently selected channel, long current program titles now scroll horizontally instead of being clipped by a single
truncateon the whole subtitle row.A new
CurrentProgramTitlecomponent drives a round-trip marquee via the Web Animations API (30px/s, 1.5s pauses at each end). It recomputes on resize (ResizeObserver), honorsprefers-reduced-motion(static truncate), and resets when the program string changes (key={currentProgram}). The subtitle row becomes a flex layout: group label stays truncated (max half width) with a separator, and the program title gets the remaining space.Non-current channels and rows without a current program keep the previous truncate behavior for group + program text.
Reviewed by Cursor Bugbot for commit db0bebf. Configure here.