fix: issue #148 #164
Open
fix: issue #148 #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobAnkh
requested changes
Jan 22, 2026
Comment on lines
+160
to
+165
| #[cfg_attr(feature = "serde", serde(default))] | ||
| pub left_external_veth: bool, | ||
|
|
||
| #[cfg_attr(feature = "serde", serde(default))] | ||
| pub right_external_veth: bool, | ||
|
|
Member
There was a problem hiding this comment.
I would rather it be an enum so that we can extend to more options besides veth. Default to optional. Rename to left_external and right_external. Currently, we can have veth only as an option.
Comment on lines
+192
to
+193
| pub left_pairs: BTreeMap<usize, Arc<VethPair>>, | ||
| pub right_pairs: BTreeMap<usize, Arc<VethPair>>, |
Member
There was a problem hiding this comment.
I don't understand why this change is necessary
Comment on lines
+20
to
+21
| use rattan_core::metal::io::af_xdp::XDPDriver as RattanPacketDriver; | ||
| use rattan_core::metal::io::af_xdp::XDPPacket as RattanPacket; |
Member
There was a problem hiding this comment.
They should still be in one line
| Duration::try_from(span) | ||
| } | ||
|
|
||
| fn add_env(handle: &mut Command, ip_list: Vec<(usize, IpAddr)>) { |
Member
There was a problem hiding this comment.
The env is conflicted with Env conceptually, so we should rename this method, e.g., add_ip_addr_env_var or something else.
| Duration::try_from(span) | ||
| } | ||
|
|
||
| fn add_env(handle: &mut Command, ip_list: Vec<(usize, IpAddr)>) { |
Member
There was a problem hiding this comment.
Let's make it a common function that can be used both by main and main-xdp. Remeber to define it at rattan crate not rattan-core crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make external veth pair optional