Add the Multi-Tenant Catalogs Endpoint Extension, for nested catalog support by jonhealy1 · Pull Request #366 · stac-utils/stac-fastapi-pgstac

jonhealy1 · 2026-03-25T12:00:05Z

Related Issue(s):

Description:

Extension spec: https://github.com/StacLabs/multi-tenant-catalogs
STAC-FastAPI catalogs extension: https://github.com/StacLabs/stac-fastapi-catalogs-extension

PR Checklist:

pre-commit hooks pass locally
Tests pass (run make test)
Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
Changes are added to the CHANGELOG.

jonhealy1 · 2026-03-25T12:05:36Z

It's going to be best to fix the extension so it supports python 3.11

…jonhealy1/stac-fastapi-pgstac into stac-fastapi-catalogs-extension

jonhealy1 · 2026-04-21T05:49:09Z

This is really close to being reviewable, just need some time to do some qa, documentation.

hrodmn

I am partway through reviewing but I found a possible bug in the catalog transactions endpoints for linking two existing catalogs.

Assuming the local Docker network/API is running at http://localhost:8082:

APP_HOST="http://localhost:8082"
SUFFIX="$(date +%Y%m%d%H%M%S)"
PARENT_1="catalog-link-repro-$SUFFIX-parent-1"
PARENT_2="catalog-link-repro-$SUFFIX-parent-2"
CHILD="catalog-link-repro-$SUFFIX-child"

# create a new parent catalog
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "'"$PARENT_1"'",
    "type": "Catalog",
    "title": "Parent 1",
    "description": "First parent catalog",
    "stac_version": "1.0.0",
    "links": []
  }' \
  "$APP_HOST/catalogs"

# create another new parent catalog
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "'"$PARENT_2"'",
    "type": "Catalog",
    "title": "Parent 2",
    "description": "Second parent catalog",
    "stac_version": "1.0.0",
    "links": []
  }' \
  "$APP_HOST/catalogs"

# Create the child under the first parent. This succeeds.
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "'"$CHILD"'",
    "type": "Catalog",
    "title": "Shared child",
    "description": "Child catalog to link under two parents",
    "stac_version": "1.0.0",
    "links": []
  }' \
  "$APP_HOST/catalogs/$PARENT_1/catalogs"

# Link the existing child under the second parent. This should succeed, but currently returns 409.
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{"id": "'"$CHILD"'"}' \
  "$APP_HOST/catalogs/$PARENT_2/catalogs"

Observed output for the final request:

POST http://localhost:8082/catalogs/<parent-2>/catalogs
curl: (22) The requested URL returned error: 409
{"code":"ConflictError","description":""}

Unit test reproduction

A failing test for this behavior can be added to tests/extensions/test_catalogs.py:

@pytest.mark.asyncio
async def test_link_existing_sub_catalog_to_second_parent(app_client):
    """Test linking an existing catalog as a sub-catalog of another parent."""
    await create_catalog(
        app_client,
        "catalog-poly-parent-1",
        description="First parent catalog for sub-catalog poly-hierarchy",
    )
    await create_catalog(
        app_client,
        "catalog-poly-parent-2",
        description="Second parent catalog for sub-catalog poly-hierarchy",
    )

    await create_sub_catalog(
        app_client,
        "catalog-poly-parent-1",
        "catalog-poly-child",
        description="Sub-catalog linked to multiple parents",
    )

    resp = await app_client.post(
        "/catalogs/catalog-poly-parent-2/catalogs", json={"id": "catalog-poly-child"}
    )
    assert resp.status_code == 200, resp.text

jonhealy1 · 2026-06-04T04:55:23Z

I am partway through reviewing but I found a possible bug in the catalog transactions endpoints for linking two existing catalogs.

Assuming the local Docker network/API is running at http://localhost:8082:

APP_HOST="http://localhost:8082"
SUFFIX="$(date +%Y%m%d%H%M%S)"
PARENT_1="catalog-link-repro-$SUFFIX-parent-1"
PARENT_2="catalog-link-repro-$SUFFIX-parent-2"
CHILD="catalog-link-repro-$SUFFIX-child"

# create a new parent catalog
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "'"$PARENT_1"'",
    "type": "Catalog",
    "title": "Parent 1",
    "description": "First parent catalog",
    "stac_version": "1.0.0",
    "links": []
  }' \
  "$APP_HOST/catalogs"

# create another new parent catalog
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "'"$PARENT_2"'",
    "type": "Catalog",
    "title": "Parent 2",
    "description": "Second parent catalog",
    "stac_version": "1.0.0",
    "links": []
  }' \
  "$APP_HOST/catalogs"

# Create the child under the first parent. This succeeds.
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "'"$CHILD"'",
    "type": "Catalog",
    "title": "Shared child",
    "description": "Child catalog to link under two parents",
    "stac_version": "1.0.0",
    "links": []
  }' \
  "$APP_HOST/catalogs/$PARENT_1/catalogs"

# Link the existing child under the second parent. This should succeed, but currently returns 409.
curl --fail-with-body --show-error --silent \
  --request POST \
  --header 'Content-Type: application/json' \
  --data '{"id": "'"$CHILD"'"}' \
  "$APP_HOST/catalogs/$PARENT_2/catalogs"

Observed output for the final request:

POST http://localhost:8082/catalogs/<parent-2>/catalogs
curl: (22) The requested URL returned error: 409
{"code":"ConflictError","description":""}

Unit test reproduction

A failing test for this behavior can be added to tests/extensions/test_catalogs.py:

@pytest.mark.asyncio
async def test_link_existing_sub_catalog_to_second_parent(app_client):
    """Test linking an existing catalog as a sub-catalog of another parent."""
    await create_catalog(
        app_client,
        "catalog-poly-parent-1",
        description="First parent catalog for sub-catalog poly-hierarchy",
    )
    await create_catalog(
        app_client,
        "catalog-poly-parent-2",
        description="Second parent catalog for sub-catalog poly-hierarchy",
    )

    await create_sub_catalog(
        app_client,
        "catalog-poly-parent-1",
        "catalog-poly-child",
        description="Sub-catalog linked to multiple parents",
    )

    resp = await app_client.post(
        "/catalogs/catalog-poly-parent-2/catalogs", json={"id": "catalog-poly-child"}
    )
    assert resp.status_code == 200, resp.text

@hrodmn Good catch! This should be fixed now

hrodmn

@jonhealy1 thanks for fixing the catalog linking bug. I reviewed the rest of the code today and my only remaining change request is to check that the parent catalog exists when adding a collection. There is similar logic in create_sub_catalog that should be copy-pastable. Please add a test for that case too!

Co-authored-by: Henry Rodman <henry.rodman@gmail.com>

jonhealy1 · 2026-06-05T03:32:37Z

@hrodmn Thanks for reviewing!

hrodmn

Thanks for this contribution @jonhealy1! I think many will find this feature useful.

bkanuka · 2026-06-08T14:27:36Z

Congrats @jonhealy1 !! Lots of solid dev work as well as balancing requirements and expectations of everyone involved. Glad I could see the journey!

bkanuka · 2026-06-08T19:04:07Z

ha I think I just caught another bug 😆 there's some double slashes in generated links. They likely need a rstrip on the base_url. I'll leave a comment

vincentsarago · 2026-06-09T10:39:53Z

thanks everyone 🙏

jonhealy1 · 2026-06-09T11:11:10Z

Thanks for all the help! @hrodmn @bkanuka @bitner @vincentsarago :)

jonhealy1 added 2 commits March 25, 2026 19:58

route extension, create, get catalogs

6570957

>= python 3.12

e05c740

jonhealy1 changed the title ~~route extension, create, get catalogs~~ Add the Multi-Tenant Virtual Catalogs Extension, for nested catalog support Mar 25, 2026

jonhealy1 changed the title ~~Add the Multi-Tenant Virtual Catalogs Extension, for nested catalog support~~ Add the Multi-Tenant Catalogs Endpoint Extension, for nested catalog support Mar 25, 2026

bitner reviewed Mar 25, 2026

View reviewed changes

Comment thread stac_fastapi/pgstac/extensions/catalogs/catalogs_database_logic.py Outdated

Merge branch 'main' into stac-fastapi-catalogs-extension

ad1ccb6

jonhealy1 mentioned this pull request Apr 4, 2026

Multi-tenant /Catalogs Extension stac-utils/stac-fastapi#880

Closed

4 tasks

jonhealy1 added 19 commits April 10, 2026 14:54

Merge branch 'main' into stac-fastapi-catalogs-extension

0964ec0

update to catalogs extension v0.1.3

ee18b97

Merge branch 'stac-fastapi-catalogs-extension' of https://github.com/…

f127857

…jonhealy1/stac-fastapi-pgstac into stac-fastapi-catalogs-extension

lint

19a166a

add to dev deps

366cf7d

change class name

7e43b20

sub-catalog scratch

1e3409b

advertise ports

6487974

sub-catalog links, tests

8fc5d83

lint

7237f29

ensure parent_ids list not returned

e8b4503

switch to collection_search pgstac

080e3fe

transaction routes scratch

59b10e1

fix poly-hierarchy

2cc1488

clean up tests

a3ac186

more test clean up

2a5fed6

update docstrings

a17e996

check, test links

d055d82

lint

050fab2

jonhealy1 mentioned this pull request Apr 21, 2026

Implementing the Multi-Tenant Virtual Catalogs STAC API Extension #376

Closed

Merge branch 'main' into stac-fastapi-catalogs-extension

c7fe5af

hrodmn reviewed Jun 2, 2026

View reviewed changes

jonhealy1 added 4 commits June 4, 2026 11:37

use get_base_url

1054995

mypy

e9f0f77

separate extensions in conftest

9a5006c

fix link catlaog by id

f66063b

jonhealy1 added 6 commits June 4, 2026 13:02

function name to _add_catalog_links

f803d87

use stronger type

b091fe6

updating parent_ids change

0a83eb6

check if catalog id in parent ids

cb41648

add comment about graph cycles

4cc8cfe

add test for linking existing catalogs

2a28d00

jonhealy1 requested review from hrodmn and vincentsarago June 4, 2026 06:10

hrodmn reviewed Jun 4, 2026

View reviewed changes

Comment thread stac_fastapi/pgstac/extensions/catalogs/catalogs_client.py

jonhealy1 and others added 2 commits June 5, 2026 11:16

Update stac_fastapi/pgstac/extensions/catalogs/catalogs_client.py

65ace44

Co-authored-by: Henry Rodman <henry.rodman@gmail.com>

test missing parent for adding collection to catalog

ac41204

jonhealy1 requested a review from hrodmn June 5, 2026 03:32

hrodmn approved these changes Jun 8, 2026

View reviewed changes

bkanuka reviewed Jun 8, 2026

View reviewed changes

Comment thread stac_fastapi/pgstac/extensions/catalogs/catalogs_client.py Outdated

use rstrip

c9e2523

vincentsarago approved these changes Jun 9, 2026

View reviewed changes

vincentsarago merged commit ac432cf into stac-utils:main Jun 9, 2026
6 checks passed

jonhealy1 deleted the stac-fastapi-catalogs-extension branch June 9, 2026 11:11

hrodmn mentioned this pull request Jun 10, 2026

Enable Multi-Tenant Catalogs Extension in STAC API runtime MAAP-Project/maap-eoapi#102

Closed

Uh oh!

Conversation

jonhealy1 commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonhealy1 commented Mar 25, 2026

Uh oh!

Uh oh!

jonhealy1 commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hrodmn left a comment

Choose a reason for hiding this comment

Unit test reproduction

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonhealy1 commented Jun 4, 2026

Unit test reproduction

Uh oh!

hrodmn left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonhealy1 commented Jun 5, 2026

Uh oh!

hrodmn left a comment

Choose a reason for hiding this comment

Uh oh!

bkanuka commented Jun 8, 2026

Uh oh!

bkanuka commented Jun 8, 2026

Uh oh!

Uh oh!

vincentsarago commented Jun 9, 2026

Uh oh!

Uh oh!

jonhealy1 commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jonhealy1 commented Mar 25, 2026 •

edited

Loading

jonhealy1 commented Apr 21, 2026 •

edited

Loading

hrodmn left a comment •

edited

Loading

jonhealy1 commented Jun 9, 2026 •

edited

Loading